Skip to content

Use requirements.txt inside setup.py #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Use requirements.txt inside setup.py #711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,17 @@
with open('README.md') as readme_file:
readme = readme_file.read()

with open('requirements.txt') as requirements_file:
requirements = requirements_file.read().split('\n')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried it and it works as if, but wanted to double check with you that we don't need to strip out the commented lines in requirements.txt
Currently, the list is:

['black', 'datasets>=1.7.0', 'flake8', 'isort==5.8.0', 'pytest', 'pyyaml>=5', 'streamlit==0.82', 'jinja2', 'plotly', 'requests', 'pandas', '##############################################################', '# Dependencies in this section are added for specific datasets', '##############################################################', 'py7zr', '##############################################################', '# End of dataset-specific dependencies', '##############################################################', '']

setup(
name='promptsource',
version='0.1.0',
url='https://github.com/bigscience-workshop/promptsource.git',
author='Multiple Authors',
author_email='xxx',
python_requires='>=3.7, <3.8',
install_requires=requirements,
classifiers=[
'Development Status :: 2 - Pre-Alpha',
'Intended Audience :: Developers',
Expand Down