Use requirements.txt inside setup.py #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Enhancement proposal. It would be great if `pip install git+https://github.com/bigscience-workshop/promptsource` would install the package dependencies. I faced this inconvenience when installing T0 repository in a clean environment. T0 only specifies `promptsource` as a dependency and because the `requirements.txt` in promptsource are not propagated into its `setup.py`, the package is installed without `sentencepiese` and `jinja2`.
VictorSanh approved these changes Jan 5, 2022
| readme = readme_file.read() | ||
| | ||
| with open('requirements.txt') as requirements_file: | ||
| requirements = requirements_file.read().split('\n') |
There was a problem hiding this comment.
i tried it and it works as if, but wanted to double check with you that we don't need to strip out the commented lines in requirements.txt
Currently, the list is:
['black', 'datasets>=1.7.0', 'flake8', 'isort==5.8.0', 'pytest', 'pyyaml>=5', 'streamlit==0.82', 'jinja2', 'plotly', 'requests', 'pandas', '##############################################################', '# Dependencies in this section are added for specific datasets', '##############################################################', 'py7zr', '##############################################################', '# End of dataset-specific dependencies', '##############################################################', '']
| Is there any reasons to still use |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Enhancement proposal.
It would be great if
pip install git+https://github.com/bigscience-workshop/promptsourcewould install the package dependencies. I faced this inconvenience when installing T0 repository in a clean environment. T0 only specifiespromptsourceas a dependency and because therequirements.txtin promptsource are not propagated into itssetup.py, the package is installed withoutsentencepieseandjinja2.