Skip to content

Add no_std support to bevy_log #20539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add no_std support to bevy_log #20539

wants to merge 1 commit into from
+120 −41

Conversation

@Shatur
Copy link
Contributor

@Shatur Shatur commented Aug 12, 2025

Objective

@bushrat011899's work on adding portable-atomic support was merged. I saw that this was backported in tokio-rs/tracing#3283 and started working on the PR. Then I realized the release hadn’t been drafted yet: tokio-rs/tracing#3282 😢
Keeping this PR as a draft for now - it only requires uncommenting 2 lines once the release drops (see the TODO in bevy_log's Cargo.toml).

Solution

Testing

  • CI

Migration Guide

  • If you were previously using bevy_log with default features disabled, enable the new std feature.
  • If you were using the bevy_log feature, remove it.
@Shatur
Add no_std support to bevy_log
c39807d 
Currently requires a new release of `tracing-subscriber`. Once released, 2 lines needs to be uncommented in `Cargo.toml`, see `TODO`.
@alice-i-cecile alice-i-cecile added A-Diagnostics Logging, crash handling, error reporting and performance analysis X-Uncontroversial This work is generally agreed upon D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Blocked This cannot move forward until something else changes M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 12, 2025
@github-actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.
@Shatur
Copy link
Contributor Author

Shatur commented Aug 12, 2025 •
edited
Loading

@alice-i-cecile But I provided a migration guide. Probably the label was added by accident.
@james7132
Copy link
Member

@\alice-i-cecile But I provided a migration guide. Probably the label was added by accident.

Might have been a bit out of date: migration guides now go in tree under the release-content directory.
@Shatur
Copy link
Contributor Author

Shatur commented Aug 12, 2025

Ah, I didn't know! Will add once tracing releases then.
@james7132
Copy link
Member

Just to jot this down somewhere: we're currently using log for bevy_ecs instead of tracing due for similar reasons why bevy_log was not supporting no_std. This PR wouldn't be a bad place to change that.
@Shatur
Copy link
Contributor Author

Shatur commented Aug 18, 2025

There are many places where log needs to be replaced with bevy_log. I think it's better to open a follow-up for replacing log everywhere 🙂

But looks like tracing won't be released in time for 0.17 😢
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Diagnostics Logging, crash handling, error reporting and performance analysis D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Blocked This cannot move forward until something else changes X-Uncontroversial This work is generally agreed upon

3 participants

@Shatur @james7132 @alice-i-cecile