Skip to content

Revert "Allow partial support for bevy_log in no_std (#18782)" #18816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

Revert "Allow partial support for bevy_log in no_std (#18782)" #18816

merged 1 commit into from
Apr 14, 2025

Conversation

@cart
Copy link
Member

@cart cart commented Apr 11, 2025 •
edited
Loading

This reverts commit ac52cca.

Fixes #18815

Objective

#18782 resulted in using log macros instead of tracing macros (in the interest of providing no_std support, specifically no_atomic support). That tradeoff isn't worth it, especially given that tracing is likely to get no_atomic support.

Solution

Revert #18782
@cart cart added the C-Bug An unexpected or incorrect behavior label Apr 11, 2025
@cart cart added this to the 0.16 milestone Apr 11, 2025
@Shatur
Copy link
Contributor

Shatur commented Apr 12, 2025 •
edited
Loading

The downside is that all third-party crates with no_std will need to depend on log directly and import it explicitly, rather than using bevy::prelude::*. However, this might be the lesser evil.
ChristopherBiscardi
ChristopherBiscardi approved these changes Apr 13, 2025
View reviewed changes
Copy link
Contributor

@ChristopherBiscardi ChristopherBiscardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #18815 for me
@cart
Copy link
Member Author

cart commented Apr 13, 2025

However, this might be the lesser evil

Yup this is the lesser evil in my book, especially given that tracing will soon support the relevant no_std scenarios.
@mockersf mockersf added this pull request to the merge queue Apr 14, 2025
Merged via the queue into bevyengine:main with commit 59bdaca Apr 14, 2025
36 checks passed
mockersf pushed a commit that referenced this pull request Apr 14, 2025
@cart @mockersf
Revert "Allow partial support for bevy_log in no_std (#18782)" (#…
dc48fd4 
…18816) This reverts commit ac52cca. Fixes #18815 the interest of providing no_std support, specifically no_atomic support). That tradeoff isn't worth it, especially given that tracing is likely to get no_atomic support. Revert #18782
@ChristopherBiscardi ChristopherBiscardi mentioned this pull request Apr 15, 2025
Closed
jf908 pushed a commit to jf908/bevy that referenced this pull request May 12, 2025
@cart @jf908
Revert "Allow partial support for bevy_log in no_std (bevyengine#…
1db5811 
…18782)" (bevyengine#18816) This reverts commit ac52cca. Fixes bevyengine#18815 # Objective bevyengine#18782 resulted in using `log` macros instead of `tracing` macros (in the interest of providing no_std support, specifically no_atomic support). That tradeoff isn't worth it, especially given that tracing is likely to get no_atomic support. ## Solution Revert bevyengine#18782
@foxzool foxzool mentioned this pull request May 26, 2025
Open
@academician academician mentioned this pull request Jun 23, 2025
Merged
@Shatur Shatur mentioned this pull request Aug 12, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Bug An unexpected or incorrect behavior

4 participants

@cart @Shatur @ChristopherBiscardi @mockersf