Skip to content

Main menu scroll fix #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2019
Merged

Main menu scroll fix #276

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49ea3c7
Change yMinLimit for 128x64
klutvott123 Oct 27, 2019
466fce4
Prevent drawScreen() from running when main menu is visible
klutvott123 Oct 27, 2019
cbc014e
Main menu scroll fixes
klutvott123 Oct 27, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prevent drawScreen() from running when main menu is visible 
Prevents it from interfering with scrollPixelsY causing scrolling to not work properly on the main menu. No need for it to run when the main menu is visible either.
  • Loading branch information
@klutvott123
klutvott123 committed Oct 27, 2019
commit 466fce4ef93e2b3df78a7663011cb6d41ff00cbe
4 changes: 3 additions & 1 deletion src/SCRIPTS/BF/ui.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,9 @@ function run_ui(event)
if TEXT_BGCOLOR then
lcd.drawFilledRectangle(0, 0, LCD_W, LCD_H, TEXT_BGCOLOR)
end
drawScreen()
if currentState ~= pageStatus.mainMenu then
drawScreen()
end
if protocol.rssi() == 0 then
lcd.drawText(radio.NoTelem[1],radio.NoTelem[2],radio.NoTelem[3],radio.NoTelem[4])
end
Expand Down