Main menu scroll fix #276
Merged
Main menu scroll fix #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Makes it the same as for 212x64
Prevents it from interfering with scrollPixelsY causing scrolling to not work properly on the main menu. No need for it to run when the main menu is visible either.
1 should not be added to currentLineY. This places the text at the top of the screen outside yMinLim causing it to disappear. Also corrected an error where yMaxLim was used instead of yMinLim.
mikeller approved these changes Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes
yMinLimitfor 128x64 to be the same as for 212x64. Makes sense as they're the same height.Prevents
drawScreen()from running when the main menu is visible. This function can changescrollPixelsYcausing the scrolling to not work as it should on the main menu. Also no need to run it when on the main menu.Removed the
+1from thecurrentLineYcalculation. Adding 1 causes the text at the top of the page to be placed outsideyMinLimand disappear.Also corrected a limit error where it should be min instead of max.
Now it works just like on the other pages. Tested and works.