Skip to content

fix(apigateway): support @app.not_found() syntax & housekeeping #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 30, 2021
Merged

fix(apigateway): support @app.not_found() syntax & housekeeping #926

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a3adb5f
fix(event-handler): allow for @app.not_found() decorator
michaelbrewer Dec 23, 2021
0b8f957
chore: rename to private and add docs
michaelbrewer Dec 24, 2021
28384c3
chore: minor docstring typos
michaelbrewer Dec 25, 2021
dcc34b0
test(idempotent): add test for sort_key_attr
michaelbrewer Dec 25, 2021
4e8329d
chore: consistently reference constants env variables
michaelbrewer Dec 27, 2021
36cb9e9
Merge branch 'develop' into fix-65
michaelbrewer Dec 29, 2021
f5685d0
refactor: revert name back to strtobool
michaelbrewer Dec 29, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: consistently reference constants env variables
  • Loading branch information
Michael Brewer committed Dec 27, 2021
commit 4e8329d6622c1a575f6a2f62f3b161a357f17ceb
6 changes: 3 additions & 3 deletions aws_lambda_powertools/utilities/idempotency/idempotency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from typing import Any, Callable, Dict, Optional, cast

from aws_lambda_powertools.middleware_factory import lambda_handler_decorator
from aws_lambda_powertools.shared.constants import IDEMPOTENCY_DISABLED_ENV
from aws_lambda_powertools.shared import constants
from aws_lambda_powertools.shared.types import AnyCallableT
from aws_lambda_powertools.utilities.idempotency.base import IdempotencyHandler
from aws_lambda_powertools.utilities.idempotency.config import IdempotencyConfig
Expand Down Expand Up @@ -58,7 +58,7 @@ def idempotent(
>>> return {"StatusCode": 200}
"""

if os.getenv(IDEMPOTENCY_DISABLED_ENV):
if os.getenv(constants.IDEMPOTENCY_DISABLED_ENV):
return handler(event, context)

config = config or IdempotencyConfig()
Expand Down Expand Up @@ -127,7 +127,7 @@ def process_order(customer_id: str, order: dict, **kwargs):

@functools.wraps(function)
def decorate(*args, **kwargs):
if os.getenv(IDEMPOTENCY_DISABLED_ENV):
if os.getenv(constants.IDEMPOTENCY_DISABLED_ENV):
return function(*args, **kwargs)

payload = kwargs.get(data_keyword_argument)
Expand Down