This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Use Strict SameSite mode for temp data cookies #6344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| I can't think of any reason why we'd want another domain to be able to use the cookie cross-domain. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reacting to aspnet/HttpAbstractions#843 Last time @rynowak and I spoke about this and it seemed that a Strict SameSite attribute is appropriate since we expect the usage to be initiated with only same-site requests. Will there be any scenarios where we would want to send this cookie along during a cross-site request?