This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Adding SameSite attribute to SetCookies header #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JunTaoLuo commented May 18, 2017
| }); | ||
| } | ||
| | ||
| private Net.Http.Headers.SameSiteEnforcementMode ConvertSameSiteEnforcementMode(SameSiteEnforcementMode sameSite) |
Contributor Author
There was a problem hiding this comment.
Not a fan of the duplication since the two enums will need conversion.
JunTaoLuo force-pushed the johluo/samesite branch from 851f68b to 007d1b2 Compare 
cesarblum reviewed May 18, 2017
| | ||
| namespace Microsoft.Net.Http.Headers | ||
| { | ||
| public enum SameSiteEnforcementMode |
Contributor
There was a problem hiding this comment.
Why do you need this in two different places?
Contributor Author
There was a problem hiding this comment.
Features and Net.Http.Headers cannot depend on each other.
| private const string SecureToken = "secure"; | ||
| private const string SameSiteToken = "samesite"; | ||
| private static readonly string SameSiteLaxToken = SameSiteEnforcementMode.Lax.ToString(); | ||
| private static readonly string SameSiteStrictToken = SameSiteEnforcementMode.Strict.ToString(); |
Contributor
There was a problem hiding this comment.
ToLower() for consistency with other tokens?
Tratcher approved these changes May 18, 2017
| | ||
| namespace Microsoft.AspNetCore.Http | ||
| { | ||
| public enum SameSiteEnforcementMode |
Member
There was a problem hiding this comment.
// This mirrors Microsoft.Net.Http.Headers.SameSiteEnforcementMode
| private const string DomainToken = "domain"; | ||
| private const string PathToken = "path"; | ||
| private const string SecureToken = "secure"; | ||
| private const string SameSiteToken = "samesite"; |
JunTaoLuo force-pushed the johluo/samesite branch 5 times, most recently from 7ce2948 to 2b60dbc Compare JunTaoLuo commented May 20, 2017
| /// Gets or sets the value for the SameSite attribute of the cookie. | ||
| /// </summary> | ||
| /// <returns>The <see cref="SameSiteEnforcementMode"/> representing the enforcement mode of the cookie.</returns> | ||
| public SameSiteEnforcementMode SameSite { get; set; } |
Tratcher reviewed May 22, 2017
| { | ||
| // RFC Draft: https://tools.ietf.org/html/draft-ietf-httpbis-cookie-same-site-00 | ||
| // This mirrors Microsoft.Net.Http.Headers.SameSiteEnforcementMode | ||
| public enum SameSiteEnforcementMode |
Member
|
|
JunTaoLuo force-pushed the johluo/samesite branch from fbf4b79 to e8123db Compare This was referenced May 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Addresses #710, will also update the CookiesPolicyMiddleware in Security.