[SPARK-50098][PYTHON] Upgrade the minimum version of googleapis-common-protos to 1.65.0 #48638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…on-protos` to 1.65.0
huaxingao approved these changes Oct 24, 2024
Contributor
huaxingao left a comment
huaxingao left a comment There was a problem hiding this comment.
LGTM. Thanks @dongjoon-hyun
Member Author
| Thank you, @huaxingao ! |
dongjoon-hyun added a commit that referenced this pull request Oct 24, 2024
…otos_version` in `setup.py` ### What changes were proposed in this pull request? This is a follow-up of - #48638 ### Why are the changes needed? To be consistent. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48643 from dongjoon-hyun/SPARK-50098-2. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit that referenced this pull request Feb 16, 2025
…m_googleapis_common_protos_version` to 1.65.0 ### What changes were proposed in this pull request? This is a follow-up of - #48638 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/python/docs/source/getting_started/install.rst?plain=1#L213 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/dev/spark-test-image/python-minimum/Dockerfile#L76 ### Why are the changes needed? To make it sure that PySpark Connect installation meets the minimum requirement correctly. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49969 from dongjoon-hyun/SPARK-50098-3. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit that referenced this pull request Feb 16, 2025
…m_googleapis_common_protos_version` to 1.65.0 ### What changes were proposed in this pull request? This is a follow-up of - #48638 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/python/docs/source/getting_started/install.rst?plain=1#L213 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/dev/spark-test-image/python-minimum/Dockerfile#L76 ### Why are the changes needed? To make it sure that PySpark Connect installation meets the minimum requirement correctly. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49969 from dongjoon-hyun/SPARK-50098-3. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit b8d395e) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Pajaraja pushed a commit to Pajaraja/spark that referenced this pull request Mar 6, 2025
…m_googleapis_common_protos_version` to 1.65.0 ### What changes were proposed in this pull request? This is a follow-up of - apache#48638 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/python/docs/source/getting_started/install.rst?plain=1#L213 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/dev/spark-test-image/python-minimum/Dockerfile#L76 ### Why are the changes needed? To make it sure that PySpark Connect installation meets the minimum requirement correctly. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49969 from dongjoon-hyun/SPARK-50098-3. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade the minimum version of
googleapis-common-protosfrom 1.56.4 to 1.65.0 for Apache Spark 4.0.0.Why are the changes needed?
1.56.4is too old (released on 2022-07-12) and incompatible with the last protobuf related libraries. We had better upgrade this to the latest versions in order to support the latest Python and protobuf versions in Apache Spark 4.0.0 on February 2025.Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.