[SPARK-50015][BUILD] Upgrade grpcio* to 1.67.0 and grpc-java to 1.67.1 #48524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dongjoon-hyun force-pushed the SPARK-50015 branch from 342a72b to eb8898c Compare 
yaooqinn approved these changes Oct 22, 2024
dongjoon-hyun force-pushed the SPARK-50015 branch from e8a7936 to 2c37776 Compare dongjoon-hyun force-pushed the SPARK-50015 branch from 2c37776 to 056191d Compare 
dongjoon-hyun force-pushed the SPARK-50015 branch from 056191d to 3cdf01a Compare 
Member Author
Member Author
| All tests passed. Thank you, @yaooqinn . |
HyukjinKwon added a commit that referenced this pull request Oct 31, 2024
…Python client 3.5 <> 4.0 server ### What changes were proposed in this pull request? This PR proposes to use the same latest Python dependencies in Python client 3.5 <> 4.0 server build. This is a sort of a followup of #48524. ### Why are the changes needed? https://github.com/apache/spark/actions/runs/11543780375/job/32128570166 fails apparently because of different grpc versions. While it is a legitimate failure to fix, that CI does not target to test all different dependency versions. It only targets 3.5cleint <> 4.0server. We should better make the test on its purpose. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Will monitor the jobs ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48719 from HyukjinKwon/SPARK-50015-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
dongjoon-hyun added a commit that referenced this pull request Feb 16, 2025
…sion` to 1.67.0 ### What changes were proposed in this pull request? This PR aims to fix PySpark Connect `_minimum_grpc_version` from 1.59.3 to 1.67.0 correctly. https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/python/docs/source/getting_started/install.rst?plain=1#L211 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/dev/spark-test-image/python-minimum/Dockerfile#L76 ### Why are the changes needed? It seems that we missed to this at - #44929 - #48524 ### Does this PR introduce _any_ user-facing change? This will make it sure that PySpark Connect installation meets the minimum requirement correctly. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49968 from dongjoon-hyun/SPARK-51227. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit that referenced this pull request Feb 16, 2025
…sion` to 1.67.0 ### What changes were proposed in this pull request? This PR aims to fix PySpark Connect `_minimum_grpc_version` from 1.59.3 to 1.67.0 correctly. https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/python/docs/source/getting_started/install.rst?plain=1#L211 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/dev/spark-test-image/python-minimum/Dockerfile#L76 ### Why are the changes needed? It seems that we missed to this at - #44929 - #48524 ### Does this PR introduce _any_ user-facing change? This will make it sure that PySpark Connect installation meets the minimum requirement correctly. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49968 from dongjoon-hyun/SPARK-51227. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 3f4ba72) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
HyukjinKwon added a commit that referenced this pull request Feb 24, 2025
…p.py for pyspark-client ### What changes were proposed in this pull request? This PR is a followup of #48524 that updates _minimum_grpc_version in setup.py for pyspark-client ### Why are the changes needed? To match the version with pyspark. ### Does this PR introduce _any_ user-facing change? No, `pyspark-client` has not been released yet. ### How was this patch tested? It will be tested in "Debug Build / Spark Connect Python-only (master, Python 3.11) " build. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50064 from HyukjinKwon/SPARK-50015-followup2. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon added a commit that referenced this pull request Feb 24, 2025
…p.py for pyspark-client ### What changes were proposed in this pull request? This PR is a followup of #48524 that updates _minimum_grpc_version in setup.py for pyspark-client ### Why are the changes needed? To match the version with pyspark. ### Does this PR introduce _any_ user-facing change? No, `pyspark-client` has not been released yet. ### How was this patch tested? It will be tested in "Debug Build / Spark Connect Python-only (master, Python 3.11) " build. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50064 from HyukjinKwon/SPARK-50015-followup2. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit ee8e10f) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Pajaraja pushed a commit to Pajaraja/spark that referenced this pull request Mar 6, 2025
…sion` to 1.67.0 ### What changes were proposed in this pull request? This PR aims to fix PySpark Connect `_minimum_grpc_version` from 1.59.3 to 1.67.0 correctly. https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/python/docs/source/getting_started/install.rst?plain=1#L211 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/dev/spark-test-image/python-minimum/Dockerfile#L76 ### Why are the changes needed? It seems that we missed to this at - apache#44929 - apache#48524 ### Does this PR introduce _any_ user-facing change? This will make it sure that PySpark Connect installation meets the minimum requirement correctly. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49968 from dongjoon-hyun/SPARK-51227. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Pajaraja pushed a commit to Pajaraja/spark that referenced this pull request Mar 6, 2025
…p.py for pyspark-client ### What changes were proposed in this pull request? This PR is a followup of apache#48524 that updates _minimum_grpc_version in setup.py for pyspark-client ### Why are the changes needed? To match the version with pyspark. ### Does this PR introduce _any_ user-facing change? No, `pyspark-client` has not been released yet. ### How was this patch tested? It will be tested in "Debug Build / Spark Connect Python-only (master, Python 3.11) " build. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50064 from HyukjinKwon/SPARK-50015-followup2. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
grpcioandgrpcio-statusto1.67.0grpc-javato1.67.1Please note that
grpc-javathere is no 1.67.0 and 1.68.0 is wrong as announced like the following.Why are the changes needed?
To use the latest updated versions as a part of Apache Spark 4.0.0 (February 2025) preparation.
Does this PR introduce any user-facing change?
Although this is a dependency change, it should be backward compatible.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.