refact(pd): remove redundant property in LogMeta & PartitionMeta #2598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dosubot bot added size:XS 
imbajin reviewed Jul 22, 2024
Member
imbajin left a comment
imbajin left a comment There was a problem hiding this comment.
Does this need to be optimized in version 1.5? Pay attention to the diff increase in subsequent versions
Contributor
I think it is possible, although it will bring some diffs. |
Member
OK, could merge it after #2599 |
JackyYangPassion approved these changes Jul 31, 2024
imbajin approved these changes Aug 2, 2024
imbajin changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
close #2597