Skip to content

[refact] The pdconfig property in LogMeta and PartitionMeta is redundant #2597

@haohao0103

Description

@haohao0103

Bug Type (问题类型)

logic (逻辑设计问题)

Before submit

  • 我已经确认现有的 IssuesFAQ 中没有相同 / 重复问题 (I have confirmed and searched that there are no similar problems in the historical issue and documents)

Environment (环境信息)

  • Server Version: 1.5.0 (Apache Release Version)
  • Backend: RocksDB x nodes, HDD

Expected & Actual behavior (期望与实际表现)

The pdconfig property in LogMeta and PartitionMeta is redundant

MetadataRocksDBStore has already defined the pdConfig property, it seems no need to redefine it in the subclass PartitionMeta

public class MetadataRocksDBStore extends MetadataStoreBase { HgKVStore store; PDConfig pdConfig; public MetadataRocksDBStore(PDConfig pdConfig) { store = MetadataFactory.getStore(pdConfig); this.pdConfig = pdConfig; } 
public class PartitionMeta extends MetadataRocksDBStore { static String CID_GRAPH_ID_KEY = "GraphID"; static int CID_GRAPH_ID_MAX = 0xFFFE; private final PDConfig pdConfig; private final PartitionCache cache; public PartitionMeta(PDConfig pdConfig) { super(pdConfig); this.pdConfig = pdConfig; //this.timeout = pdConfig.getEtcd().getTimeout(); this.cache = new PartitionCache(); } 

Vertex/Edge example (问题点 / 边数据举例)

No response

Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpdPD modulerocksdbRocksDB backend

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions