Skip to content

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part4. #7647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025
Merged

HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part4. #7647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b20681
HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part4.
zhtttylz May 23, 2025
0d448fd
replace wildcard static imports with explicit ones.
zhtttylz May 26, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ...-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestAdminHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
*/
package org.apache.hadoop.hdfs.tools;

import org.junit.Assert;
import org.junit.Test;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

/**
* Test class to test Admin Helper.
Expand All @@ -28,11 +30,10 @@ public class TestAdminHelper {
@Test
public void prettifyExceptionWithNpe() {
String pretty = AdminHelper.prettifyException(new NullPointerException());
Assert.assertTrue(
assertTrue(pretty.startsWith("NullPointerException at org.apache.hadoop.hdfs.tools"
+ ".TestAdminHelper.prettifyExceptionWithNpe"),
"Prettified exception message doesn't contain the required exception "
+ "message",
pretty.startsWith("NullPointerException at org.apache.hadoop.hdfs.tools"
+ ".TestAdminHelper.prettifyExceptionWithNpe"));
+ "message");
}

@Test
Expand All @@ -42,7 +43,7 @@ public void prettifyException() {
new IllegalArgumentException("Something is wrong",
new IllegalArgumentException("Something is illegal")));

Assert.assertEquals(
assertEquals(
"IllegalArgumentException: Something is wrong",
pretty);

Expand Down
Loading