- Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part4. #7647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 💔 -1 overall
This message was automatically generated. |
3b74067 to 5eb8500 Compare | 🎊 +1 overall
This message was automatically generated. |
5eb8500 to 58f1902 Compare | 🎊 +1 overall
This message was automatically generated. |
| public void prettifyExceptionWithNpe() { | ||
| String pretty = AdminHelper.prettifyException(new NullPointerException()); | ||
| Assert.assertTrue( | ||
| Assertions.assertTrue(pretty.startsWith("NullPointerException at org.apache.hadoop.hdfs.tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to use static import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I'll update the code as soon as possible.
58f1902 to 5558aa1 Compare | 💔 -1 overall
This message was automatically generated. |
| 💔 -1 overall
This message was automatically generated. |
28e9b0a to f0a1ec1 Compare f0a1ec1 to 5fe19e5 Compare | 💔 -1 overall
This message was automatically generated. |
| 💔 -1 overall
This message was automatically generated. |
5fe19e5 to 9b71eb0 Compare | 💔 -1 overall
This message was automatically generated. |
9b71eb0 to 07cef39 Compare | 💔 -1 overall
This message was automatically generated. |
42bde4b to c7ac68c Compare | 💔 -1 overall
This message was automatically generated. |
| 💔 -1 overall
This message was automatically generated. |
574c42c to 0c2a754 Compare | 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
5a42b8e to ca1fec4 Compare | 🎊 +1 overall
This message was automatically generated. |
b49ea28 to 7b20681 Compare | 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
| import org.junit.jupiter.api.Test; | ||
| | ||
| import static org.junit.Assert.*; | ||
| import static org.junit.jupiter.api.Assertions.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I'll update the code as soon as possible.
| @cnauroth @Hexiaoqiao Could you help review this PR? Thank you very much! |
| 🎊 +1 overall
This message was automatically generated. |
| @zhtttylz Thanks for the contribution! LGTM. |
| @cnauroth @Hexiaoqiao, do you have time to review this PR? I’d really appreciate your insights. Thanks a lot! |
cnauroth left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. LGTM. Thank you @zhtttylz ! Thank you @slfan1989 for reviewing too.
| Thanks @cnauroth and @slfan1989 for reviewing and merging! The remaining parts will be submitted soon. |
…pache#7647) * HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part4. Co-authored-by: Chris Nauroth <cnauroth@apache.org> Co-authored-by: Shilun Fan <slfan1989@apache.org> Reviewed-by: Chris Nauroth <cnauroth@apache.org> Reviewed-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
Description of PR
JIRA:HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part4.
How was this patch tested?
Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?