YARN-11261. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-web-proxy #4777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Contributor Author
| @aajisaka - Please help in reviewing the PR. Thanks. |
Contributor Author
| @aajisaka - As discussed, added |
| 🎊 +1 overall
This message was automatically generated. |
Contributor Author
| @aajisaka - Please help in reviewing the PR. Thanks. |
aajisaka requested changes Sep 10, 2022
Member
aajisaka left a comment
aajisaka left a comment There was a problem hiding this comment.
It's great to see you refactored several assertions. Added 2 comments to refactor more
| setupKDC(); | ||
| } catch (Exception e) { | ||
| assertTrue("Couldn't create MiniKDC", false); | ||
| assertTrue(false, "Couldn't create MiniKDC"); |
Member
There was a problem hiding this comment.
Here, we should use fail("Couldn't create MiniKDC");
https://junit.org/junit5/docs/5.8.2/api/org.junit.jupiter.api/org/junit/jupiter/api/Assertions.html#fail(java.lang.String)
| testHelper(false); | ||
| } catch (ApplicationNotFoundException e) { | ||
| Assert.assertTrue(e.getMessage() == appNotFoundExceptionMsg); | ||
| assertTrue(e.getMessage() == appNotFoundExceptionMsg); |
Member
There was a problem hiding this comment.
We can refactor as assertEquals(appNotFoundExceptionMsg, e.getMessage())
| 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
Contributor Author
| @aajisaka - I have addressed you comments. Please help in review. Thanks. |
aajisaka approved these changes Sep 13, 2022
Member
aajisaka left a comment
aajisaka left a comment There was a problem hiding this comment.
+1, thank you for your update.
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
…apache#4777) Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of PR
Upgrade JUnit from 4 to 5 in hadoop-yarn-server-web-proxy
JIRA - YARN-11261
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?