Addressing comments

Author: Ashutosh Gupta

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestAppReportFetcher.java

@@ -34,6 +34,7 @@
 import org.apache.hadoop.yarn.exceptions.ApplicationNotFoundException;
 import org.apache.hadoop.yarn.exceptions.YarnException;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assertions.fail;
 
@@ -79,7 +80,7 @@ void testFetchReportAHSDisabled() throws YarnException, IOException {
  try {
  testHelper(false);
  } catch (ApplicationNotFoundException e) {
- assertTrue(e.getMessage() == appNotFoundExceptionMsg);
+ assertEquals(appNotFoundExceptionMsg, e.getMessage());
  /* RM will not know of the app and Application History Service is disabled
  * So we will not try to get the report from AHS and RM will throw
  * ApplicationNotFoundException

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/amfilter/TestSecureAmFilter.java

@@ -44,6 +44,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
 
 /**
  * Test AmIpFilter. Requests to a no declared hosts should has way through
@@ -89,7 +90,7 @@ public static void setUp() {
  testMiniKDC = new MiniKdc(MiniKdc.createConf(), TEST_ROOT_DIR);
  setupKDC();
  } catch (Exception e) {
- assertTrue(false, "Couldn't create MiniKDC");
+ fail("Couldn't create MiniKDC");
  }
  }