Skip to content

feat(common): add component input binding support for NgComponentOutlet #50736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HyperLife1119
Copy link
Contributor

This commit add component input binding support for NgComponentOutlet.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from alxhub June 15, 2023 17:02
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jun 15, 2023
@HyperLife1119 HyperLife1119 force-pushed the support-component-outlet-inputs branch from 336de98 to 0f32953 Compare June 15, 2023 17:14
This commit add component input binding support for NgComponentOutlet.
@HyperLife1119 HyperLife1119 force-pushed the support-component-outlet-inputs branch from 0f32953 to e6b02c4 Compare June 15, 2023 17:17
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package labels Jun 16, 2023
@ngbot ngbot bot modified the milestone: Backlog Jun 16, 2023
@ankitkaushik24
Copy link
Contributor

Can we please merge this crucial feature @alxhub

@AndrewKushnir AndrewKushnir added the target: minor This PR is targeted for the next minor release label Jul 17, 2023
@pkozlowski-opensource pkozlowski-opensource self-assigned this Jul 19, 2023
@pkozlowski-opensource
Copy link
Member

@HyperLife1119 sorry it took us a bit of time to take care of this PR - some of the internal Google tests were failing and we had to investigate. I do have a changed version (see a fixup commit) in #51148.

I'm going to close this PR and work towards landing #51148 instead (the commit will be attributed to you as an author).

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
4 participants