- Notifications
You must be signed in to change notification settings - Fork 26.4k
feat(common): add component input binding support for NgComponentOutlet #49735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): add component input binding support for NgComponentOutlet #49735
Conversation
67ba3d5
to be0612e
Compare 442c106
to 7a3804d
Compare Should partially close #15360 |
8812256
to fcf66d9
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it check if key is an input in the component. Because if it is not, it will throw error. We can use ComponentMirror to check.
@gmfun It will only throw in dev mode and throwing is exactly what we want rather than silently ignoring invalid inputs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
1c242b9
to 2783954
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-common
This PR was merged into the repository by commit f386759. |
This PR was reverted due to breakages in the existing Google applications, will need investigation. |
Adding "blocked" label since this PR will require investigation on our side before merging. |
angular#49735 was reverted we need to adjust the changelog accordingly.
2783954
to 4550fe4
Compare Sorry, due to an incorrect rebase operation, the PR has been transferred to #50736. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…et (angular#49735) This commit add component input binding support for NgComponentOutlet. PR Close angular#49735
This commit add component input binding support for NgComponentOutlet.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information