Skip to content

feat(common): add component input binding support for NgComponentOutlet #49735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HyperLife1119
Copy link
Contributor

@HyperLife1119 HyperLife1119 commented Apr 6, 2023

This commit add component input binding support for NgComponentOutlet.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 6, 2023
@HyperLife1119 HyperLife1119 force-pushed the support-component-outlet-inputs branch 2 times, most recently from 67ba3d5 to be0612e Compare April 6, 2023 16:55
@HyperLife1119 HyperLife1119 changed the title feat(common): add component input support for NgComponentOutlet feat(common): add component input binding support for NgComponentOutlet Apr 6, 2023
@HyperLife1119 HyperLife1119 force-pushed the support-component-outlet-inputs branch 2 times, most recently from 442c106 to 7a3804d Compare April 6, 2023 17:17
@destus90
Copy link
Contributor

destus90 commented Apr 7, 2023

Should partially close #15360

@HyperLife1119 HyperLife1119 force-pushed the support-component-outlet-inputs branch 3 times, most recently from 8812256 to fcf66d9 Compare April 8, 2023 06:51
Copy link

@gmfun gmfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it check if key is an input in the component. Because if it is not, it will throw error. We can use ComponentMirror to check.

@atscott
Copy link
Contributor

atscott commented Apr 10, 2023

@gmfun It will only throw in dev mode and throwing is exactly what we want rather than silently ignoring invalid inputs.

@atscott atscott added the target: minor This PR is targeted for the next minor release label Apr 11, 2023
@pullapprove pullapprove bot requested review from atscott and jessicajaniuk April 11, 2023 16:35
@jessicajaniuk jessicajaniuk added the area: common Issues related to APIs in the @angular/common package label Apr 12, 2023
@ngbot ngbot bot added this to the Backlog milestone Apr 12, 2023
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@jessicajaniuk jessicajaniuk added the action: merge The PR is ready for merge by the caretaker label Apr 17, 2023
@ngbot
Copy link

ngbot bot commented Apr 17, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    failure status "google-internal-tests" is failing
    pending status "mergeability" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jessicajaniuk jessicajaniuk added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Apr 17, 2023
@HyperLife1119 HyperLife1119 force-pushed the support-component-outlet-inputs branch from 1c242b9 to 2783954 Compare June 7, 2023 15:32
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-common

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews state: blocked labels Jun 7, 2023
@alxhub
Copy link
Member

alxhub commented Jun 8, 2023

This PR was merged into the repository by commit f386759.

@alxhub alxhub closed this in f386759 Jun 8, 2023
alxhub added a commit that referenced this pull request Jun 8, 2023
…nentOutlet (#49735)" This reverts commit f386759. This PR has property renaming bugs in g3.
@pkozlowski-opensource
Copy link
Member

This PR was reverted due to breakages in the existing Google applications, will need investigation.

@pkozlowski-opensource
Copy link
Member

Adding "blocked" label since this PR will require investigation on our side before merging.

@JeanMeche JeanMeche removed the action: merge The PR is ready for merge by the caretaker label Jun 12, 2023
@pkozlowski-opensource pkozlowski-opensource removed this from the v16.1 candidates milestone Jun 12, 2023
@ngbot ngbot bot added this to the Backlog milestone Jun 12, 2023
pkozlowski-opensource added a commit to pkozlowski-opensource/angular that referenced this pull request Jun 13, 2023
angular#49735 was reverted we need to adjust the changelog accordingly.
pkozlowski-opensource added a commit that referenced this pull request Jun 13, 2023
#49735 was reverted we need to adjust the changelog accordingly. PR Close #50707
@HyperLife1119 HyperLife1119 force-pushed the support-component-outlet-inputs branch from 2783954 to 4550fe4 Compare June 15, 2023 16:51
@angular-robot angular-robot bot removed the detected: feature PR contains a feature commit label Jun 15, 2023
@HyperLife1119
Copy link
Contributor Author

Sorry, due to an incorrect rebase operation, the PR has been transferred to #50736.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 16, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…et (angular#49735) This commit add component input binding support for NgComponentOutlet. PR Close angular#49735
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: common Issues related to APIs in the @angular/common package state: blocked target: minor This PR is targeted for the next minor release