perf(core): debounce scrollHandler in uiGridHeader and uiGridViewport #5378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use scrollDebounce param from global ui-grid options.
Contributor
| What is the behaviour before and what is the behaviour now? How has it changed? |
Author
| Before,
This has major performance impact, noticeable especially for the case of You may be interested in Google results for javascript debounce scroll event |
* Add missing translations : Language French * Update fr.js
Fix paths to the files.
Fix link for project website, http://ui-grid.info/, for Font Awesome css and user newer version of Font Awesome
selectRow doesn't work when ui-grid-selection is enabled together with ui-grid-tree-view. getRow returns first div in the row which will be the node expand/collapse icon's div if tree view is enabled.
The documentation for `refresh` method (line 218) should be updated to include optional param `rowsAltered`
Added separator parameter documentation in the formatAsCsv function
… to top/bottom quickly (angular-ui#5183)
WheelEvent.deltaMode is a READONLY property, as explained https://developer.mozilla.org/en-US/docs/Web/API/WheelEvent/deltaMode and by the error message my browser throws. This should not be reset to zero.
…arameter (angular-ui#5404) * Fixing notify text if cellFilter takes string literal Calling getCellDisplayValue to get the correct filtered value, instead of getIntersectionValueFiltered, which did not return the correct value if the cellFIlter contained a string literal as an argument. This was the only place that function was being used, so it can be removed. It was probably carried forward from the ng-grid source, which had the same issue. * Remove getIntersectionValueFiltered This function was probably carried forward from ng-grid, and does not properly handle cellFilters with string literal arguments. It was only being used in one place, and was easily replaced with getCellDisplayValue, which does return the proper value.
Sauce keeps failing on master, this is the first attempt to fix it
This fix removes an unneeded additional function when setting column visibility. Since both functions were of the same priority level, it was possible that the visibility that was passed in would be overwritten with the default value of true under certain circumstances. There was really no need for two functions, as this default behavior can be accomplished in one.
…Header and uiGridViewport is even better
Member
| @lootek Can you resolve merge conflicts? |
Contributor
| Can you please rebase your changes instead of merging up? |
Member
| Closing due to inactivity. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use scrollDebounce param from global ui-grid options.