docs(infinite-scroll): remove $q dependency and deprecated $http promises #5364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
corburn force-pushed the doc-infinite-scroll branch from 9d15c6a to f4ffa9b Compare 
lootek pushed a commit to lootek/ui-grid that referenced this pull request Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove $q dependency because $http already returns a Promise.
https://github.com/petkaantonov/bluebird/wiki/Promise-anti-patterns
Replace deprecated $http success/error promise methods with then/catch
https://docs.angularjs.org/api/ng/service/$http