Skip to content

fix(specs): allow one sided rule validity #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025
+332 −177
Merged

fix(specs): allow one sided rule validity #5060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31106b7
fix(specs): allow one sided rule validity
millotp Jul 4, 2025
af50f4e
fix the guides
millotp Jul 4, 2025
b8af42c
Merge branch 'main' into fix/timerange
millotp Jul 4, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions specs/common/schemas/Rule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,3 @@ timeRange:
type: integer
format: int64
description: When the rule should stop to be active, in Unix epoch time.
required:
- from
- until
9 changes: 5 additions & 4 deletions templates/go/guides/search/useConditionlessRule.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@ func useConditionlessRule() {
*search.NewConsequence(/* Set relevant consequence */),
). // Set validity (optional)
SetValidity(
[]search.TimeRange{
*search.NewTimeRange(1_688_774_400, 1_738_972_800),
},
)
[]search.TimeRange{ {
From: utils.ToPtr(int64(1_688_774_400)),
Until: utils.ToPtr(int64(1_738_972_800)),
}},
)

_, err = {{#dynamicSnippet}}saveRule{{/dynamicSnippet}}
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions templates/scala/guides/search/useConditionlessRule.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ def useConditionlessRule(): Future[Unit] = {
// Set validity (optional)
validity = Some(Seq(
TimeRange(
from = 1_688_774_400,
until = 1_738_972_800
from = Some(1_688_774_400),
until = Some(1_738_972_800)
)
))
)
Expand Down
Loading