Skip to content

fix(specs): allow one sided rule validity #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2025
Merged

fix(specs): allow one sided rule validity #5060

merged 3 commits into from
Jul 4, 2025
+332 −177

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 4, 2025 •
edited by atlassian bot
Loading

🧭 What and Why

🎟 JIRA Ticket: CR-8889

Time ranges for rule can be one sided, we can't express that in openapi without using a one of, so we just make them both optional.
@millotp millotp requested a review from a team as a code owner July 4, 2025 08:40
@millotp millotp requested review from Fluf22 and morganleroi July 4, 2025 08:40
@millotp millotp self-assigned this Jul 4, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 4, 2025 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by 43b30a03accfaaa59beca37652e3520cf7b4b07a
🍃 Generated commit 8ba91da8aaff5faf1a79628699ffd6d0a2f7ae0e
🌲 Generated branch generated/fix/timerange
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1784
javascript 1629
php 1482
csharp 1351
java 1077
python 1070
ruby 803
swift 352
scala 23
shortcuts
shortcuts approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bc for go no?
@millotp
Copy link
Collaborator Author

millotp commented Jul 4, 2025

this is a bc for go no?

indeed, and scala, but the spec was not correct so it's still a fix right ?
@shortcuts
Copy link
Member

this is a bc for go no?

indeed, and scala, but the spec was not correct so it's still a fix right ?

yup, just makes me think that we should have a way to properly reflect those in changelogs
@millotp millotp enabled auto-merge (squash) July 4, 2025 10:59
@millotp millotp merged commit 754efce into main Jul 4, 2025
29 checks passed
@millotp millotp deleted the fix/timerange branch July 4, 2025 11:09
algolia-bot added a commit that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (#5060) (generated) [skip ci]
2f3ea2e 
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (generated)
b7129c0 
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (generated)
340d539 
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (generated)
bdd0741 
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (generated)
732ca82 
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (generated)
b36cb5b 
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (generated)
d7a4d4c 
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (generated)
79e704a 
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (generated)
b1b28ff 
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (generated)
e1ab063 
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (generated)
0afec08 
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jul 4, 2025
@algolia-bot @millotp
fix(specs): allow one sided rule validity (generated)
bfb46d1 
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@millotp @algolia-bot @shortcuts