net: mgmt: Support for Passive scan #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
krish2718 suggested changes Jun 7, 2023
include/zephyr/net/wifi_mgmt.h Outdated
include/zephyr/net/wifi_mgmt.h Outdated
There was a problem hiding this comment.
This is a breaking change, so, need to:
- Update release notes
- Fix all Wi-Fi drivers
subsys/net/l2/wifi/Kconfig Outdated
There was a problem hiding this comment.
Default should be active scan as passive is only used to handle regulatory restrictions, any specific reason for default passive? And also this changes the current behaviour completely.
[Edit: Looking at code below this only means, PASSIVE scan support]
There was a problem hiding this comment.
Add support to force scan in passive-only mode. Currently, this support is already present via wifi utils. We need to add Kconfig option to set the default mode to passive and provide UMAC API to use to change this at run time if needed.
For all the below comments, Please check
https://nordicsemi.atlassian.net/browse/SHEL-1628 &
https://nordicsemi.atlassian.net/browse/SHEL-1568
There was a problem hiding this comment.
Ok, got some clarity. Will change accordingly.
There was a problem hiding this comment.
The Kconfig in wifi_shell isn't useful, I guess the Kconfig override should be in the driver to always do passive scan e.g., for regulatory tests
subsys/net/l2/wifi/Kconfig Outdated
There was a problem hiding this comment.
Why do we even need this? This doesn't save any memory, so, we can enable this always.
subsys/net/l2/wifi/wifi_shell.c Outdated
Comment on lines 451 to 453
There was a problem hiding this comment.
We can get this from the shell, as mentioned above Kconfig can be removed.
subsys/net/l2/wifi/wifi_shell.c Outdated
There was a problem hiding this comment.
Default is active, and is using -p better, we can use getopt? Its only a flag.
ajayparida force-pushed the passive_scan_option branch 2 times, most recently from 2e7c478 to cdc5e62 Compare krish2718 reviewed Jun 7, 2023
subsys/net/l2/wifi/wifi_shell.c Outdated
There was a problem hiding this comment.
Still not so useful, as we already have a shell option. See #1 (comment)
There was a problem hiding this comment.
ok done....moved to driver. Please check
ajayparida force-pushed the passive_scan_option branch from cdc5e62 to 8a73d86 Compare krish2718 reviewed Jun 8, 2023
subsys/net/l2/wifi/Kconfig Outdated
There was a problem hiding this comment.
This can now be removed or moved to driver Kconfig. Or if you think its useful for all drivers, then we can use it to hardcode passive scan mode in wifi_mgmt.
ajayparida force-pushed the passive_scan_option branch from 8a73d86 to 9c94060 Compare krish2718 reviewed Jun 8, 2023
subsys/net/l2/wifi/wifi_shell.c Outdated
There was a problem hiding this comment.
ok, fixed this. Please update. incase it will be better to move to wifi_mgmt.
ESP driver seems to have this option.
ajayparida force-pushed the passive_scan_option branch 4 times, most recently from a31ee77 to 4f0e08c Compare krish2718 reviewed Jun 12, 2023
There was a problem hiding this comment.
Add a comment here
Suggested change
| scan_config->scan_type = params->scan_type; | |
| /* The enum values are same, so, no conversion needed */ | |
| scan_config->scan_type = params->scan_type; |
subsys/net/l2/wifi/Kconfig Outdated
There was a problem hiding this comment.
Suggested change
| This option sets passive scan. | |
| Force passive scan, the scan type is always sent as passive, | |
| this doesn't guarantee that passive scan will be used, it depends | |
| on the underlying chip implementation to support and honour scan type. |
subsys/net/l2/wifi/Kconfig Outdated
There was a problem hiding this comment.
Suggested change
| bool "Forced Passive scan" | |
| bool "Force Passive scan" |
subsys/net/l2/wifi/wifi_shell.c Outdated
There was a problem hiding this comment.
This is suggested by Sachin for keeping it similar to "iw".
ajayparida force-pushed the passive_scan_option branch from 4f0e08c to ddb3e90 Compare krish2718 approved these changes Jun 13, 2023
krish2718 reviewed Jun 13, 2023
drivers/wifi/simplelink/simplelink.c Outdated
There was a problem hiding this comment.
We should either add
ARG_UNUSED(params)- or assuming most chipsets only support active (but this assumption might not be true)
if (params->scan_type != ACTIVE) return -ENOTSUP; 
Adds properties to configure OCTOSPI IO Manager data lines. That allows to use any `IOLowPort` and `IOHightPort`. Note: OSPIM requires additional clock to be enabled. Please refer to Reference Manual. Extra clock can be enabled in devicetree. Signed-off-by: Georgij Cernysiov <geo.cgv@gmail.com>
Allows to configure OSPI Manager IO ports with devicetree. If properties are absent, then original default values are preserved for compatibility. Signed-off-by: Georgij Cernysiov <geo.cgv@gmail.com>
`fpscr` is assigned from `struct __fpu_sf.fpscr` in `vfp_restore`, but it wasn't saved into `struct __fpu_sf.fpscr` in the svc and isr handler, So it may be a dirty value. - Fix it by saving `fpscr` in the svc hand isr handler. - Jump out if FPU isn't enabled Signed-off-by: Huifeng Zhang <Huifeng.Zhang@arm.com>
This adds support for 32 double-precision registers in the context switching of aarch32 architecture. Signed-off-by: Huifeng Zhang <Huifeng.Zhang@arm.com>
This commit is to enable FPU and FPU_SHARING for v8r aarch32. Signed-off-by: Huifeng Zhang <Huifeng.Zhang@arm.com>
- Remove raising compilation error in `float_regs_arm_gcc.h` These macros are checked in 'load_store.c', so no need to check them again in 'float_regs_arm_gcc.h' - Enable this test on the VFP platform of aarch32 Signed-off-by: Huifeng Zhang <Huifeng.Zhang@arm.com>
Use double type when FPU supports double precision. Signed-off-by: Huifeng Zhang <Huifeng.Zhang@arm.com>
evt_type is 16 bits and thus requires endianness conversion over HCI Signed-off-by: Troels Nilsson <trnn@demant.com>
The argument to the dmic irq is of type "struct device *" and dmic data is actually part of it, thus make the cast correctly. Signed-off-by: Jaska Uimonen <jaska.uimonen@linux.intel.com>
Don't assume the connection handle will always be 0. This is currently the case with the Zephyr link layer, but recently changed in the Softdevice Controller. Another problem is that apparently the spec allows the controller to just blackhole data instead of returning `BT_HCI_ERR_UNKNOWN_CONN_ID` if the host uses a wrong handle. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
If the address was removed immediately after being added (e.g. because the interface MAC address is changed on boot), it would remain in the DAD timer list. In one scenario, the DAD timeout would eventually fire, causing the now-removed address to be modified, potentially causing issues that way. In another scenario, if the interface was immediately brought back up again with a different link-local address, this new address would reuse the first address slot on the interface. Starting the DAD process for this new address would lead to the same address slot being added to the DAD timer list a second time, causing an infinite list and associated lockup during iteration. Always remove the address from the DAD timer list when it is removed from the interface, not just when DAD fails. Signed-off-by: Armin Brauns <armin.brauns@embedded-solutions.at>
Provisionee shall fail if provisioner sent public key identicall to OOB public key back. Signed-off-by: Aleksandr Khromykh <aleksandr.khromykh@nordicsemi.no>
Since the mtl platform, the stereo bit has been removed from the CIC_CONTROL register and now it is marked as reserved. On some platforms (mtl and above), the configuration blob still has this bit set, causing the dmic driver to report an error. This commit changes the behavior of the driver to only display a warning. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Trivial update that was missed. Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Adds i2c2 on nucleo_f746zg to use the i2c_target_api test case to enables the board. Signed-off-by: Marc Desvaux <marc.desvaux-ext@st.com>
Adds necessary overlay nucleo_f746zg in i2c_target_api test case to enables the board. Signed-off-by: Marc Desvaux <marc.desvaux-ext@st.com>
Currently, it is not possible to use hawkbit with code that requires POSIX_API to be set due to the dependency on NET_SOCKETS_POSIX_NAMES. Since a lot of other code has already been moved to `zsock_`, this commit does the same for hawkbit. Co-authored-by: rojedag <r.ojeda@vogl-electronic.com> Signed-off-by: Matthias Breithaupt <m.breithaupt@vogl-electronic.com>
Instead of setting the default_stream when we initiate the configure operatio, we set it when it has succeded. In case that the codec configure fails, the stream should not really be considered configured as the default. This also ensures that the default_stream is set when using the CAP shell commands. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Unnecessary mbedtls config option has been removed from ble mesh KConfig. Signed-off-by: Aleksandr Khromykh <aleksandr.khromykh@nordicsemi.no>
PTS l2cap tests need BT_BUF_ACL_RX_SIZE to be 100. Signed-off-by: Lang Xie <Lang.Xie@nordicsemi.no> Signed-off-by: Magdalena Kasenberg <magdalena.kasenberg@codecoup.pl>
Update Nuvoton numaker series pinctrl, let support pin group. Signed-off-by: cyliang tw <cyliang@nuvoton.com>
Use Zephyr internal zsock_ calls to remove dependency to NET_SOCKETS_POSIX_NAMES. Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
After exiting D3 state if IMR context save is enabled, IDC interrupt must be re-enabled again for all cores. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
Move the creation of the multicast solicited node address outside the loop. There is no functional change but it prepares for some future changes. Signed-off-by: Florian Vaussard <florian.vaussard@gmail.com>
First search for a match, then perform the removal outside the loop. There is no functional change but this prepares for some future changes. Signed-off-by: Florian Vaussard <florian.vaussard@gmail.com>
Two different IPv6 addresses can have the same solicited node multicast address, for example when they are derived from the same EUI-64 interface identifier during the auto-configuration process. For example, an interface with a physical address 70:07:12:34:56:78 can have the following: - link-local address FE80::7207:12FF:FE34:5678 - global unicast address 2001:1234:::7207:12FF:FE34:5678 Both addresses will have the same solicited-node multicast address FF02::1:FF34:5678. Currently, if one removes the global unicast address, the solicited-node multicast address is also removed, leaving the link-local address out of the solicited-node multicast group. This breaks some protocols like Neighbour Discovery. Count how many times the solicited-node multicast address is used and remove it only if it is not shared by any other unicast address. Fixes zephyrproject-rtos#59683 Signed-off-by: Florian Vaussard <florian.vaussard@gmail.com>
The value of in6addr_mcast is overwritten in iface_setup() before being assigned to the interface. Remove the useless initial value since it is never used, in order to avoid misleading information. Signed-off-by: Florian Vaussard <florian.vaussard@gmail.com>
If two IPv6 addresses have the same solicited-node multicast address because they derive from the same EUI-64 interface identifier, make sure that the solicited-node multicast address is not removed when one of the IPV6 address is removed but only when both addresses are removed. Signed-off-by: Florian Vaussard <florian.vaussard@gmail.com>
…M data The Zephyr linker scripts have inconsistent ordering of various chunks of data which lands in RAM at runtime. This leads to the value of _end not being consistently defined as the maximum address of static variables used in the application. Create a helper linker fragment, zephyr/linker/ram-end.ld, which can be included after the last possible definition of RAM data, that consistently sets _image_ram_end, _end and z_mapped_end. Signed-off-by: Keith Packard <keithp@keithp.com>
The generated scripts don't include a definition for any symbol indicating the end of statically allocated memory (such as "_end"). Add a shared cmake fragment, ram-end.cmake, which contains the necessary instructions to define _end and z_mapped_end consistently to align with the other sample linker scripts. Signed-off-by: Keith Packard <keithp@keithp.com>
ajayparida force-pushed the passive_scan_option branch 2 times, most recently from 84a26a0 to 8275a73 Compare Use only single thread for handling polling of the sockets. Each client will have only 1 active socket which to poll. Each client can have multiple simultaneous requests ongoing. The client only has one buffer for receiving and one buffer for sending. Therefore the messages are reformed when resending. Signed-off-by: Jarno Lämsä <jarno.lamsa@nordicsemi.no>
Test handling multiple requests. Signed-off-by: Jarno Lämsä <jarno.lamsa@nordicsemi.no>
Add a config "fixture_auxdisplay" to make the samples/drivers/auxdisplay runnable on a platform, else the application is useless This fixture will differ from the existing "fixture_display" Signed-off-by: Francois Ramu <francois.ramu@st.com>
Add myself as collaborator for the networking subsystem. Signed-off-by: Sjors Hettinga <s.a.hettinga@gmail.com>
ajayparida force-pushed the passive_scan_option branch 4 times, most recently from f934018 to 017080f Compare Default scan mode is Active. User can force the scan mode to passive through Kconfig option or using 'passive' option from shell. Using either of this option will override regulatory settings and forces all scan channels to be passive only. Signed-off-by: Ajay Parida <ajay.parida@nordicsemi.no>
Added Wi-Fi passive scan support related info. Signed-off-by: Ajay Parida <ajay.parida@nordicsemi.no>
ajayparida force-pushed the passive_scan_option branch from 017080f to c29c03c Compare ajayparida pushed a commit that referenced this pull request Jun 26, 2025
Add possibility to perform crop on all pipes and compose (downscale) on pixel pipes (endpoint #1 and endpoint zephyrproject-rtos#2). Rework the code in order to move the downscale control from the set_fmt into the set_selection (compose). Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Default scan mode is set to Passive. User can select current scan mode through Kconfig option. User can override current set scan mode by passing optional parameter 'active' or 'passive'.