- Notifications
You must be signed in to change notification settings - Fork 4.9k
[DB sources] : Exit when encountering a config error #38538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits Select commit Hold shift + click to select a range
7cc02a0 Exit when encountering a config erro
akashkulk 5b1249d Fix
akashkulk 64d0b7f toggle cdk
akashkulk b8cf8f9 Merge branch 'master' into akash/config-error
akashkulk c551aee Merge branch 'master' into akash/config-error
akashkulk a9dc3eb comment out
akashkulk f6ad9a9 Merge branch 'master' into akash/config-error
akashkulk 6d688a6 fix
akashkulk 125e391 Disable config error tests in integration test runner
akashkulk a3ba64b Uncomment tests
akashkulk 7c2bbcc Mock out testReadException
akashkulk c589d93 enable testREadException
akashkulk bafea3d revert
akashkulk f8c1b6b FIx check
akashkulk 0589919 Merge branch 'master' into akash/config-error
akashkulk 74f1707 Merge branch 'master' into akash/config-error
akashkulk 69f6b25 toggle mssql and mysql
akashkulk 6a3cf33 Merge branch 'master' into akash/config-error
akashkulk d9d9073 revert build.gradle
akashkulk 09ce5a4 Merge branch 'master' into akash/config-error
akashkulk e29db84 Merge branch 'master' into akash/config-error
akashkulk 1e0d2f4 Fix versions
akashkulk 527c71c Revert postgres docs
akashkulk 2584e72 Merge branch 'master' into akash/config-error
akashkulk 398c5ae Bump cdk once agaain
akashkulk c9f5789 Merge branch 'master' into akash/config-error
akashkulk 3e39f14 toggle
akashkulk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion 2 airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| version=0.36.1 | ||
| version=0.36.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you explain why we need to remove this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test fails now that we are properly exiting when catching the exception. We are changing the behavior of re-throwing the exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, in this case, we might be interested in using this JUnit rule to verify the exit status:
https://stefanbirkner.github.io/system-rules/#ExpectedSystemExit