[DB sources] : Exit when encountering a config error #38538
Conversation
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii added area/connectors octavia-squidington-iii added the area/documentation 
| cdkVersionRequired = '0.35.11' | ||
| features = ['db-sources'] | ||
| useLocalCdk = false | ||
| useLocalCdk = true |
There was a problem hiding this comment.
not sure if we need to merge this change (and the ones above and below) ?
There was a problem hiding this comment.
Will revert this when cdk is published and is toggled
| | ||
| @Test | ||
| @Throws(Exception::class) | ||
| fun testReadException() { |
There was a problem hiding this comment.
could you explain why we need to remove this test?
There was a problem hiding this comment.
This test fails now that we are properly exiting when catching the exception. We are changing the behavior of re-throwing the exception
There was a problem hiding this comment.
I see, in this case, we might be interested in using this JUnit rule to verify the exit status:
https://stefanbirkner.github.io/system-rules/#ExpectedSystemExit
| /publish-java-cdk
|
| /publish-java-cdk
|
Currently, sources don't exit when encountering a config error, but instead default to the behavior of rethrowing. This causes
AirbyteExceptionHandlerto throw a system error thereby causing config errors to be reported to Sentry (potentially paging the OC rotation).Fix here is to treat config errors the same as transient errors and exit as soon as they are encountered