This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Minor fix on handling headers in OpenAIClient #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hi @langchain4j , I noticed that the release |
langchain4j approved these changes Mar 19, 2024
| @singularity-sg I am going to do another release (0.16.0) today or tomorrow, it will include the fix. |
| @singularity-sg 0.16.0 is released |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up bug fix to an earlier PR #19 that sets the generic header interceptor only when
CustomHeadersare present. We should inject other headers fromUser-AgentorOrganization-Idregardless of the presence ofCustomHeaderscc: @langchain4j