This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Allow additional headers in the OpenAiClient #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
singularity-sg force-pushed the singularity-sg/allow-headers-in-openai-client branch from 75b09b3 to 925669f Compare 
langchain4j previously approved these changes Mar 12, 2024
There was a problem hiding this comment.
@singularity-sg great job, thanks you! Just a small nitpick regarding naming :)
ai-for-java pushed a commit that referenced this pull request Mar 12, 2024
…derInjector before RequestLoggingInterceptor, so that all headers are logged
singularity-sg deleted the singularity-sg/allow-headers-in-openai-client branch ai-for-java pushed a commit that referenced this pull request Mar 19, 2024
# Description This is a follow up bug fix to an earlier PR #19 that sets the generic header interceptor only when `CustomHeaders` are present. We should inject other headers from `User-Agent` or `Organization-Id` regardless of the presence of `CustomHeaders` cc: @langchain4j
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
We want to extend the OpenAiClient so that additional headers could be inserted into the client for reasons like network routing/usage control/audits etc.
Approach
I've simply added the
additionalHeadersfield into the OpenAiClient so that it can be used by an interceptor for injecting headers whenever a call is made to OpenAI or a proxy.