support optional text_background_color for cards #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kattni approved these changes Dec 13, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 29, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.4 from 0.5.3: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#12 from Neradoc/version-and-repo Updating https://github.com/adafruit/Adafruit_CircuitPython_FancyLED to 1.4.7 from 1.4.6: > Merge pull request adafruit/Adafruit_CircuitPython_FancyLED#26 from adafruit/pb-rgbw > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.3.4 from 3.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#60 from FoamyGuy/pwmio_types_str Updating https://github.com/adafruit/Adafruit_CircuitPython_PYOA to 2.5.1 from 2.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#31 from tekktrik/doc/add-typing > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#29 from FoamyGuy/background_fix > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#30 from FoamyGuy/text_background_color Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.10.4 from 1.10.3: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#91 from Neradoc/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I noticed that one of the cards in the
cyoa/example has a grid of grey pixels for it's background image with black text on top of it.The grid makes the text pixelated and a little difficult to read.
I've added a new
text_background_colorproperty that can be specified int he card configuration JSON to set a desired background color on the labeled, and modified that one page to use this new feature to put a more contrasting color behind the text.Here is the slide with the current library (including the background img fix from #29):
Here is the slide with the changes from this PR:
