Skip to content

fix backgrounds and remove CP6 compatibility #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2021
Merged

fix backgrounds and remove CP6 compatibility #29

merged 1 commit into from
Dec 13, 2021

Conversation

@FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Dec 11, 2021 •
edited
Loading

resolves #28

There were a few options to resolve this:

  1. remove with context and add a exception for pylint
  2. remove the CP6 compatibility version now that 7 has a stable release. Starting with CP7 the filename can be passed directly to OnDiskBitmap which avoids the library needing to open or managed the open file at all. Instead we just pass the string filepath to OnDiskBitmap and it handles the file internally.

I went with option 2 since we do have a 7 stable release now and since doing it this way doesn't require the pylint exception.

Tested successfully on PyPortal:

Adafruit CircuitPython 7.1.0-beta.0 on 2021-11-12; Adafruit PyPortal with samd51j20 Board ID:pyportal
@FoamyGuy FoamyGuy requested a review from a team December 11, 2021 17:03
@FoamyGuy FoamyGuy mentioned this pull request Dec 11, 2021
Merged
@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Dec 11, 2021

Here are some photos that illustrate this issue and fix.

Current version of library on the home screen of cyoa example:
pyoa_image_before

Fixed version from this PR same page:

pyoa_image_after
tannewt
tannewt approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@tannewt tannewt merged commit fb786ea into adafruit:main Dec 13, 2021
@tannewt
Copy link
Member

tannewt commented Dec 13, 2021

FYI I added today's bundle as the last supported 6.x bundle: https://learn.adafruit.com/welcome-to-circuitpython/frequently-asked-questions
@dhalbert dhalbert mentioned this pull request Dec 14, 2021
Merged
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 29, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@e796bc0)
df41a12 
Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.4 from 0.5.3: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#12 from Neradoc/version-and-repo Updating https://github.com/adafruit/Adafruit_CircuitPython_FancyLED to 1.4.7 from 1.4.6: > Merge pull request adafruit/Adafruit_CircuitPython_FancyLED#26 from adafruit/pb-rgbw > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.3.4 from 3.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#60 from FoamyGuy/pwmio_types_str Updating https://github.com/adafruit/Adafruit_CircuitPython_PYOA to 2.5.1 from 2.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#31 from tekktrik/doc/add-typing > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#29 from FoamyGuy/background_fix > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#30 from FoamyGuy/text_background_color Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.10.4 from 1.10.3: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#91 from Neradoc/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@FoamyGuy @tannewt