Update pop text syntax #6251
Merged
Update pop text syntax #6251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
tlively force-pushed the parser-tuple-sets branch from 88464e0 to 76afc4c Compare 18 tasks
kripken approved these changes Jan 29, 2024
tlively force-pushed the parser-tuple-sets branch from 76afc4c to 84abc7d Compare tlively force-pushed the pop-syntax branch 2 times, most recently from 4ada05f to 07d53b6 Compare tlively force-pushed the parser-tuple-sets branch from f57ade3 to 8d373d8 Compare 
Rather than `(pop valtype*)`, use `(pop valtype)`, where `valtype` is now allowed to be a tuple. This will make it possible to parse un-folded multivalue pops in the new text parser. The alternative would have been to put an arity in the syntax like we have for other tuple instructions, but that's much uglier.
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
Rather than `(pop valtype*)`, use `(pop valtype)`, where `valtype` is now allowed to be a tuple. This will make it possible to parse un-folded multivalue pops in the new text parser. The alternative would have been to put an arity in the syntax like we have for other tuple instructions, but that's much uglier.
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Rather than
(pop valtype*), use(pop valtype), wherevaltypeis nowallowed to be a tuple. This will make it possible to parse un-folded multivalue
pops in the new text parser. The alternative would have been to put an arity in
the syntax like we have for other tuple instructions, but that's much uglier.