[Parser] Parse local.set and global.set of tuple values correctly #6250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Merged
tlively force-pushed the parser-tuple-sets branch from 88464e0 to 76afc4c Compare 18 tasks
kripken approved these changes Jan 29, 2024
tlively force-pushed the parser-tuple-types branch from 4a4c934 to d823f1c Compare tlively force-pushed the parser-tuple-sets branch from 76afc4c to 84abc7d Compare 
These instructions always pop a single value, except when tuples are involved, in which case they need special handling to know how many values to pop.
tlively force-pushed the parser-tuple-sets branch from f57ade3 to 8d373d8 Compare radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
…bAssembly#6250) These instructions always pop a single value, except when tuples are involved, in which case they need special handling to know how many values to pop.
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These instructions always pop a single value, except when tuples are involved,
in which case they need special handling to know how many values to pop.