[bugfix] Fix MLA-793 Make Unity lifecycle methods protected. Added tests for changes #3590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chriselion reviewed Mar 7, 2020
| @@ -0,0 +1,2 @@ | |||
| <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation"> | |||
There was a problem hiding this comment.
It was added automatically by Rider. 🤷♂
chriselion reviewed Mar 7, 2020
chriselion approved these changes Mar 7, 2020
mmattar reviewed Mar 7, 2020
| | ||
| protected override void OnEnable() | ||
| { | ||
| if (callBase) |
| { | ||
| throw new UnityAgentsException("Call to SendInfoToBrain when Agent hasn't been initialized." + | ||
| "Please ensure that you are calling 'base.OnEnable()' if you have overridden OnEnable."); | ||
| |
| - `AgentInfo.actionMasks` has been renamed to `AgentInfo.discreteActionMasks`. | ||
| - `DecisionRequester` has been made internal (you can still use the DecisionRequesterComponent from the inspector). `RepeatAction` was renamed `TakeActionsBetweenDecisions` for clarity. (#3555) | ||
| - The `IFloatProperties` interface has been removed. | ||
| - Fix #3579. |
There was a problem hiding this comment.
Lets expand with a 1-liner and then have a link to the Issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Address issue raised in #3579.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
#3579
https://jira.unity3d.com/browse/MLA-739
Types of change(s)
Checklist
Other comments