Skip to content

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Jul 28, 2020

Fixes #1147.

Original PR #3980. All credits to @reefman001. Had to recreate due issues with Github CLI.

image


This PR:

  • adds a new subcomponent DropdownText to handle shorthands (nothing important actually)
  • images and flags are now visible in single selection

image
image

  • renderLabel in Dropdown has a new default value that allows to show images and flags in multiple variations

image

@github-actions
Copy link

size-limit report

Path Size
bundle-size/dist/Button.size.js 70.84 KB (0%)
bundle-size/dist/Icon.size.js 33.41 KB (0%)
bundle-size/dist/Image.size.js 66.13 KB (0%)
bundle-size/dist/Portal.size.js 49.9 KB (0%)
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020

Codecov Report

Merging #4003 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #4003 +/- ## ======================================= Coverage 99.84% 99.84% ======================================= Files 184 185 +1 Lines 3234 3245 +11 ======================================= + Hits 3229 3240 +11  Misses 5 5 
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100.00% <100.00%> (ø)
src/modules/Dropdown/DropdownText.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ec408...31767d4. Read the comment docs.

…ub.com/Semantic-Org/Semantic-UI-React into fix_dropdown_icon_#1147 � Conflicts: �	src/modules/Dropdown/Dropdown.js �	test/specs/modules/Dropdown/Dropdown-test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants