Skip to content

Conversation

@knight-coder-llc
Copy link
Contributor

@knight-coder-llc knight-coder-llc commented Jul 9, 2020

Fixes #1147.

Updated drop down component icon not rendering with selection. #1147 fixed icon display with selected value from drop down menu.

@welcome
Copy link

welcome bot commented Jul 9, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

Codecov Report

Merging #3980 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3980 +/- ## ======================================= Coverage 99.84% 99.84% ======================================= Files 180 180 Lines 3169 3172 +3 ======================================= + Hits 3164 3167 +3  Misses 5 5 
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d851d...6103e8b. Read the comment docs.

@layershifter layershifter changed the title Fix dropdown icon #1147 feat(Dropdown): add support for images, icons and flags in selected values Jul 28, 2020
@layershifter
Copy link
Member

@reefman001 I used Github CLI to get your branch locally but it broke references to repositories:

image

So I can't push changes to your fork at all 💣 That's why I am closing this and opened #4003.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants