Skip to content

Update exceptions.py #15862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Update exceptions.py #15862

merged 1 commit into from
Jun 5, 2025

Conversation

@adolfoarmas
Copy link
Contributor

@adolfoarmas adolfoarmas commented Jun 5, 2025 •
edited by qodo-merge-pro bot
Loading

User description

Update urls to the correct troubleshooting links:

-https://www.selenium.dev/documentation/webdriver/troubleshooting/errors/#nosuchelementexception

-https://www.selenium.dev/documentation/webdriver/troubleshooting/errors/#staleelementreferenceexception

-https://www.selenium.dev/documentation/webdriver/troubleshooting/errors/#invalidselectorexception

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Documentation

Description

  • Update error documentation URLs in exception messages

  • Ensure links point to correct troubleshooting sections

  • Minor cleanup for consistency in exception classes

Changes walkthrough 📝

Relevant files
Documentation
exceptions.py
Correct error documentation URLs in exception classes       

py/selenium/common/exceptions.py

  • Updated URLs in exception constructors to correct troubleshooting
    anchors
  • Ensured consistency in error documentation links for three exceptions
  • No logic or functional changes, only documentation references updated
    		• +3/-3     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •
    @CLAassistant
    Copy link

    CLAassistant commented Jun 5, 2025 •
    edited
    Loading

    CLA assistant check
    All committers have signed the CLA.
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 5, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected
    @selenium-ci selenium-ci added the C-py Python Bindings label Jun 5, 2025
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 5, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.
    @cgoldberg cgoldberg self-requested a review June 5, 2025 15:04
    cgoldberg
    cgoldberg approved these changes Jun 5, 2025
    View reviewed changes
    Copy link
    Member

    @cgoldberg cgoldberg left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM 👍
    Thanks for the contribution!

    Note: CI jobs are failing on this PR, but I don't see how it could be related to these changes. I will investigate separately.
    @cgoldberg cgoldberg merged commit 2d2cb13 into SeleniumHQ:trunk Jun 5, 2025
    14 of 19 checks passed
    Delta456
    Delta456 reviewed Jun 5, 2025
    View reviewed changes
    Copy link
    Member

    @Delta456 Delta456 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks for updating the links.

    You also need to make a change here so that the CI doesn't fail.
    @cgoldberg
    Copy link
    Member

    cgoldberg commented Jun 5, 2025

    @Delta456 ouch.. I already merged it. I'll fix that now. 1 sec.
    cgoldberg added a commit that referenced this pull request Jun 5, 2025
    @cgoldberg
    Revert "[py] Update urls to the correct troubleshooting links (#15862)"
    2586e66 
    This reverts commit 2d2cb13.
    @cgoldberg cgoldberg mentioned this pull request Jun 5, 2025
    Merged
    @Delta456
    Copy link
    Member

    Delta456 commented Jun 5, 2025

    @Delta456 ouch.. I already merged it. I'll fix that now. 1 sec.

    Please don't revert it as I made a PR at #15863
    @adolfoarmas
    Copy link
    Contributor Author

    adolfoarmas commented Jun 5, 2025

    @Delta456

    You also need to make a change here so that the CI doesn't fail.

    Good to know, thank you!
    @cgoldberg cgoldberg mentioned this pull request Jun 5, 2025
    Merged
    cgoldberg added a commit that referenced this pull request Jun 5, 2025
    @cgoldberg
    [py] Re-apply #15862 (#15865)
    24a16fb
    @cgoldberg
    Copy link
    Member

    cgoldberg commented Jun 5, 2025

    @Delta456 it should be all set now. thanks
    @cgoldberg cgoldberg mentioned this pull request Jun 5, 2025
    Merged
    This was referenced Sep 12, 2025
    Closed
    Closed
    Merged
    This was referenced Sep 19, 2025
    Closed
    Closed
    Closed
    This was referenced Oct 1, 2025
    Closed
    Closed
    Closed
    @dependabot dependabot bot mentioned this pull request Oct 24, 2025
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    C-py Python Bindings Review effort 1/5

    5 participants

    @adolfoarmas @CLAassistant @cgoldberg @Delta456 @selenium-ci