Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
9e753a7
Remove extraneous JS file
rjmholt May 10, 2021
0f5f5e0
Debugging dependency injection
rjmholt Apr 20, 2021
744fd88
Get UI debugger running
rjmholt Apr 21, 2021
0c21f19
Resolve commented-out code
rjmholt May 10, 2021
4cc3f77
Improve queue implementation
rjmholt May 25, 2021
cdd4e3e
Add async error handling code
rjmholt May 10, 2021
248008a
Rework execution queue to allow correct cancellation
rjmholt Jun 21, 2021
a001af4
TEMP: Need to fix cancellation from PSRL scope
rjmholt Jun 28, 2021
b5b3325
TEMP: Moving to monolithic host
rjmholt Jul 20, 2021
5428be9
WIP
rjmholt Aug 4, 2021
d3f8e01
Move all basic functionality into a new synchronous internal host
rjmholt Aug 13, 2021
502e4bb
Restore host to simple working order
rjmholt Aug 24, 2021
9ddfd9c
Add simple cancellation support
rjmholt Aug 30, 2021
942e7a6
Ensure startup operations are performed before first prompt
rjmholt Aug 30, 2021
ec9517f
Fix dependency issue
rjmholt Aug 30, 2021
d50ea57
Fix incorrect remote runspace labelling
rjmholt Aug 30, 2021
22d6088
Begin to make the debugger work
rjmholt Aug 30, 2021
6883f1e
Fix recursive PSRL cancellation token issue in debugger
rjmholt Sep 1, 2021
5fa2c4a
Enable proper debug UI interaction
rjmholt Sep 2, 2021
aaf27f7
Fix remote session connection
rjmholt Sep 3, 2021
d4ec378
Check the current runspace for debug API support
rjmholt Sep 8, 2021
b0af038
Fix debug disconnect handling
rjmholt Sep 9, 2021
a1c94be
Make remote debugger function correctly
rjmholt Sep 14, 2021
b5aab6e
Remove dead code
rjmholt Sep 15, 2021
b66cb0a
Remove more dead code
rjmholt Sep 15, 2021
e8bc341
Add comment about remote debugging
rjmholt Sep 15, 2021
822f0cc
Rename event handler
rjmholt Sep 15, 2021
a08855f
Add ConfigureAwait(false)
rjmholt Sep 15, 2021
797d38b
Make psEditor variable name a constant
rjmholt Sep 15, 2021
c8a691f
Remove debug cancellation token
rjmholt Sep 15, 2021
a6789aa
Remove duplicated check
rjmholt Sep 15, 2021
2d16735
Add comment
rjmholt Sep 15, 2021
b39e1fa
Add data structure for interlocked latch pattern
rjmholt Sep 15, 2021
298cbf1
Move cancellation token argument to end of methods
rjmholt Sep 15, 2021
e9521ff
Make BlockingConcurrentDeque disposable
rjmholt Sep 15, 2021
c9b782f
Rename PSES InternalHost to PsesInternalHost
rjmholt Oct 5, 2021
c39e298
Change WriteErrorsToHost to ThrowOnError
rjmholt Oct 5, 2021
fc4f0f4
Make default PowerShellExecutionOptions static
rjmholt Oct 7, 2021
fdb3ea3
Remove PowerShellContextService
rjmholt Oct 7, 2021
bbf838c
Ensure ConfigureAwait(false) is used everywhere
rjmholt Oct 7, 2021
fbdd818
Fix debugger evaluation not being written out
rjmholt Oct 7, 2021
bd07885
Add comment about nameless variables
rjmholt Oct 7, 2021
3207481
Use nicer pattern matching for condition
rjmholt Oct 7, 2021
98272ff
Add TODO about debugger disconnection handling
rjmholt Oct 7, 2021
2230ef9
Convert to `is null` for consistency
rjmholt Oct 7, 2021
bd19fae
Remove unused dependencies
rjmholt Oct 7, 2021
1fd44f6
Use AllThreadsContinued consistently
rjmholt Oct 7, 2021
22868f6
Add comment about debug context lifetime
rjmholt Oct 7, 2021
09b962d
Add context to comment
rjmholt Oct 7, 2021
e19878a
Fix breakpoint API test
rjmholt Oct 8, 2021
c2797d1
Fix ThrowOnError configuration check
rjmholt Oct 8, 2021
0f62b1d
Ensure the DSC module import fails with an error
rjmholt Oct 8, 2021
1a62125
Remove unneeded async/await
rjmholt Oct 8, 2021
0480ab6
Add comment explaining remote debug setting
rjmholt Oct 8, 2021
1d1cab8
Remove unused enum
rjmholt Oct 8, 2021
029539a
Add comment to execution options class
rjmholt Oct 8, 2021
03f18aa
Add comment to synchronous task about synchronous results
rjmholt Oct 8, 2021
a07e7da
Ensure F8 works
rjmholt Oct 8, 2021
25d38a1
Add comment about not exiting the top level
rjmholt Oct 8, 2021
268eb5f
Generalize exit handling
rjmholt Oct 8, 2021
15b16f0
Add comment about remote prompt
rjmholt Oct 9, 2021
1e98e9c
Simplify nested PowerShell creation
rjmholt Oct 9, 2021
d21efeb
Use a more explicit return
rjmholt Oct 9, 2021
543dabe
Fix Ctrl-C detection
rjmholt Oct 9, 2021
963fba1
Rename debug event handlers
rjmholt Oct 11, 2021
f5b644e
Remove unneeded PSRL static ctor call - PSRL is now loaded on the pip…
rjmholt Oct 11, 2021
905686c
Move execution service to an interface
rjmholt Oct 11, 2021
0a69937
Enhance remoting comment
rjmholt Oct 11, 2021
da786c8
Turn on psedit registration in remote sessions
rjmholt Oct 11, 2021
fb08b67
Ensure failed remote file saves are logged
rjmholt Oct 11, 2021
1f52dde
Add comment about IsExternalInit
rjmholt Oct 11, 2021
27a1735
Reinstate runspace cleanup logic
rjmholt Oct 11, 2021
87022dc
Fix remote psedit registration
rjmholt Oct 11, 2021
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment about remote debugging
  • Loading branch information
rjmholt committed Oct 5, 2021
commit e8bc3413c2e4e81b8fb27cec9c641fa67d2793c6
2 changes: 1 addition & 1 deletion src/PowerShellEditorServices/Server/PsesDebugServer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public async Task StartAsync()
// The OnInitialize delegate gets run when we first receive the _Initialize_ request:
// https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Initialize
.OnInitialize(async (server, request, cancellationToken) => {
// Ensure the debugger mode is set correctly
// Ensure the debugger mode is set correctly - this is required for remote debugging to work
_debugContext.EnableDebugMode();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for self: want to see what this method does.


var breakpointService = server.GetService<BreakpointService>();
Expand Down