- Notifications
You must be signed in to change notification settings - Fork 240
Fix debugging with PSES pipeline thread changes #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rjmholt merged 73 commits into PowerShell:async-ps-consumer from rjmholt:pipelinethread-fix-debugging Oct 11, 2021
Merged
Changes from 1 commit
Commits
Show all changes
73 commits Select commit Hold shift + click to select a range
9e753a7 Remove extraneous JS file
rjmholt 0f5f5e0 Debugging dependency injection
rjmholt 744fd88 Get UI debugger running
rjmholt 0c21f19 Resolve commented-out code
rjmholt 4cc3f77 Improve queue implementation
rjmholt cdd4e3e Add async error handling code
rjmholt 248008a Rework execution queue to allow correct cancellation
rjmholt a001af4 TEMP: Need to fix cancellation from PSRL scope
rjmholt b5b3325 TEMP: Moving to monolithic host
rjmholt 5428be9 WIP
rjmholt d3f8e01 Move all basic functionality into a new synchronous internal host
rjmholt 502e4bb Restore host to simple working order
rjmholt 9ddfd9c Add simple cancellation support
rjmholt 942e7a6 Ensure startup operations are performed before first prompt
rjmholt ec9517f Fix dependency issue
rjmholt d50ea57 Fix incorrect remote runspace labelling
rjmholt 22d6088 Begin to make the debugger work
rjmholt 6883f1e Fix recursive PSRL cancellation token issue in debugger
rjmholt 5fa2c4a Enable proper debug UI interaction
rjmholt aaf27f7 Fix remote session connection
rjmholt d4ec378 Check the current runspace for debug API support
rjmholt b0af038 Fix debug disconnect handling
rjmholt a1c94be Make remote debugger function correctly
rjmholt b5aab6e Remove dead code
rjmholt b66cb0a Remove more dead code
rjmholt e8bc341 Add comment about remote debugging
rjmholt 822f0cc Rename event handler
rjmholt a08855f Add ConfigureAwait(false)
rjmholt 797d38b Make psEditor variable name a constant
rjmholt c8a691f Remove debug cancellation token
rjmholt a6789aa Remove duplicated check
rjmholt 2d16735 Add comment
rjmholt b39e1fa Add data structure for interlocked latch pattern
rjmholt 298cbf1 Move cancellation token argument to end of methods
rjmholt e9521ff Make BlockingConcurrentDeque disposable
rjmholt c9b782f Rename PSES InternalHost to PsesInternalHost
rjmholt c39e298 Change WriteErrorsToHost to ThrowOnError
rjmholt fc4f0f4 Make default PowerShellExecutionOptions static
rjmholt fdb3ea3 Remove PowerShellContextService
rjmholt bbf838c Ensure ConfigureAwait(false) is used everywhere
rjmholt fbdd818 Fix debugger evaluation not being written out
rjmholt bd07885 Add comment about nameless variables
rjmholt 3207481 Use nicer pattern matching for condition
rjmholt 98272ff Add TODO about debugger disconnection handling
rjmholt 2230ef9 Convert to `is null` for consistency
rjmholt bd19fae Remove unused dependencies
rjmholt 1fd44f6 Use AllThreadsContinued consistently
rjmholt 22868f6 Add comment about debug context lifetime
rjmholt 09b962d Add context to comment
rjmholt e19878a Fix breakpoint API test
rjmholt c2797d1 Fix ThrowOnError configuration check
rjmholt 0f62b1d Ensure the DSC module import fails with an error
rjmholt 1a62125 Remove unneeded async/await
rjmholt 0480ab6 Add comment explaining remote debug setting
rjmholt 1d1cab8 Remove unused enum
rjmholt 029539a Add comment to execution options class
rjmholt 03f18aa Add comment to synchronous task about synchronous results
rjmholt a07e7da Ensure F8 works
rjmholt 25d38a1 Add comment about not exiting the top level
rjmholt 268eb5f Generalize exit handling
rjmholt 15b16f0 Add comment about remote prompt
rjmholt 1e98e9c Simplify nested PowerShell creation
rjmholt d21efeb Use a more explicit return
rjmholt 543dabe Fix Ctrl-C detection
rjmholt 963fba1 Rename debug event handlers
rjmholt f5b644e Remove unneeded PSRL static ctor call - PSRL is now loaded on the pip…
rjmholt 905686c Move execution service to an interface
rjmholt 0a69937 Enhance remoting comment
rjmholt da786c8 Turn on psedit registration in remote sessions
rjmholt fb08b67 Ensure failed remote file saves are logged
rjmholt 1f52dde Add comment about IsExternalInit
rjmholt 27a1735 Reinstate runspace cleanup logic
rjmholt 87022dc Fix remote psedit registration
rjmholt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add comment about nameless variables
- Loading branch information
commit bd07885c9bcdfd26134b9f2c2c40d00e70c6a699
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were we getting variables back with no name...?