Skip to content

Add OpenCV to preinstalled components #5519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add OpenCV to preinstalled components #5519

wants to merge 1 commit into from

Conversation

@SunBlack
Copy link
Contributor

@SunBlack SunBlack commented Nov 21, 2022

OpenCV is required for some components:

  • GPU Kinfu (optional)
  • Tutorials davidSDK & Ensenso Cameras (required)
@SunBlack SunBlack mentioned this pull request Nov 21, 2022
Open
@larshg
Copy link
Contributor

larshg commented Nov 21, 2022

I would rather remove / deprecate things that use OpenCV.
If people want to do combined work I would suggest to do it in 3. party repos.
@mvieth
Copy link
Member

mvieth commented Nov 18, 2023

I would rather remove / deprecate things that use OpenCV. If people want to do combined work I would suggest to do it in 3. party repos.

I agree, we should not have/install OpenCV as a dependency. Code that requires OpenCV should be removed, or even better, adapted to work without OpenCV
@mvieth mvieth closed this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@SunBlack @larshg @mvieth