CMake op_library function #2897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* It is used to create an operator library. It handles to split CPU and GPU sources and links operator common libraries. * It also give a reasonable warning and error when operator developer not correctly implement an operator. * Warning for lack of GPU kernel. * Same interface as `cc_library` to make code style consistent.
reyoung commented Jul 16, 2017
| else() | ||
| cc_library(add_op SRCS add_op.cc DEPS operator op_registry glog ddim) | ||
| endif() | ||
| function(op_library TARGET) |
There was a problem hiding this comment.
This not in generic.cmake because it is only used by building an operator, not a generic function.
QiJune reviewed Jul 17, 2017
paddle/operators/CMakeLists.txt Outdated
| # for ops. | ||
| set(cc_srcs) | ||
| set(cu_srcs) | ||
| set(op_common_deps operator op_registry glog ddim) |
There was a problem hiding this comment.
paddle_memory is also needed for an operator
There was a problem hiding this comment.
It is very useful to make Tensor a library. Then we can propagate dependencies of tensor library. (Like eigen3 in future.)
reyoung force-pushed the feature/op_library branch from 35a6e78 to 38310f9 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
GPU sources and links operator common libraries.
not correctly implement an operator.
cc_libraryto make code style consistent.