Merge pull request #2897 from reyoung/feature/op_library

CMake `op_library` function

Author: reyoung

paddle/framework/CMakeLists.txt

@@ -1,19 +1,19 @@
-# ddim lib
+cc_library(enforce SRCS enforce.cc DEPS glog)
+cc_test(enforce_test SRCS enforce_test.cc DEPS enforce)
 cc_library(ddim SRCS ddim.cc)
 cc_test(ddim_test SRCS ddim_test.cc DEPS ddim)
 nv_test(dim_test SRCS dim_test.cu DEPS ddim)
-cc_test(tensor_test SRCS tensor_test.cc DEPS ddim glog gflags)
+cc_library(tensor SRCS tensor.cc DEPS ddim place enforce paddle_memory)
+cc_test(tensor_test SRCS tensor_test.cc DEPS tensor)
 cc_test(variable_test SRCS variable_test.cc)
 cc_test(scope_test SRCS scope_test.cc)
-cc_library(enforce SRCS enforce.cc DEPS glog gflags)
-cc_test(enforce_test SRCS enforce_test.cc DEPS enforce)
 proto_library(attr_type SRCS attr_type.proto)
 proto_library(op_proto SRCS op_proto.proto DEPS attr_type)
 cc_test(op_proto_test SRCS op_proto_test.cc DEPS op_proto protobuf)
 proto_library(op_desc SRCS op_desc.proto DEPS attr_type)
 cc_test(op_desc_test SRCS op_desc_test.cc DEPS op_desc protobuf)
 
-cc_library(operator SRCS operator.cc DEPS op_desc device_context enforce)
+cc_library(operator SRCS operator.cc DEPS op_desc device_context tensor)
 cc_test(operator_test SRCS operator_test.cc DEPS operator op_registry)
 
 cc_library(op_registry SRCS op_registry.cc DEPS op_proto op_desc enforce)

paddle/framework/tensor.cc

@@ -0,0 +1,19 @@
+/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserve.
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. */
+
+#include <paddle/framework/tensor.h>
+
+namespace paddle {
+namespace framework {}
+} // namespace paddle

paddle/operators/CMakeLists.txt

@@ -1,6 +1,44 @@
-if(WITH_GPU)
- nv_library(add_op SRCS add_op.cc add_op.cu DEPS operator op_registry glog ddim)
-else()
- cc_library(add_op SRCS add_op.cc DEPS operator op_registry glog ddim)
-endif()
+function(op_library TARGET)
+ # op_library is a function to create op library. The interface is same as
+ # cc_library. But it handle split GPU/CPU code and link some common library
+ # for ops.
+ set(cc_srcs)
+ set(cu_srcs)
+ set(op_common_deps operator op_registry)
+ set(options "")
+ set(oneValueArgs "")
+ set(multiValueArgs SRCS DEPS)
+ cmake_parse_arguments(op_library "${options}" "${oneValueArgs}"
+ "${multiValueArgs}" ${ARGN})
+
+ foreach(src ${op_library_SRCS})
+ if (${src} MATCHES ".*\\.cu$")
+ list(APPEND cu_srcs ${src})
+ elseif(${src} MATCHES ".*\\.cc$")
+ list(APPEND cc_srcs ${src})
+ else()
+ message(FATAL_ERROR "${TARGET} Source file ${src} should only be .cc or .cu")
+ endif()
+ endforeach()
+
+ list(LENGTH cc_srcs cc_srcs_len)
+ if (${cc_srcs_len} EQUAL 0)
+ message(FATAL_ERROR "The op library ${TARGET} should contains at least one .cc file")
+ endif()
+
+ list(LENGTH cu_srcs cu_srcs_len)
+ if (${cu_srcs_len} EQUAL 0)
+ message(WARNING "The op library ${TARGET} not support GPU!")
+ endif()
+
+ if (WITH_GPU)
+ nv_library(${TARGET} SRCS ${cc_srcs} ${cu_srcs} DEPS ${op_library_DEPS}
+ ${op_common_deps})
+ else()
+ cc_library(${TARGET} SRCS ${cc_srcs} DEPS ${op_library_DEPS}
+ ${op_common_deps})
+ endif()
+endfunction()
+
+op_library(add_op SRCS add_op.cc add_op.cu)
 cc_test(add_op_test SRCS add_op_test.cc DEPS add_op)