Write the Understand Sentiment book example with stacked LSTM using new API #10355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
abhinavarora requested review from cs2be, daming-lu, helinwang, jetfuel, sidgoyal78 and wangkuiyi 
sidgoyal78 reviewed May 3, 2018
| | ||
| place = fluid.CUDAPlace(0) if use_cuda else fluid.CPUPlace() | ||
| trainer = fluid.Trainer( | ||
| partial(train_network, word_dict), |
There was a problem hiding this comment.
Nice use of partial. But probably we will have to think about how the Trainer API will parse both functions and functools.partial objects (for any use case except calling them).
There was a problem hiding this comment.
This has already been addressed offline. https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/fluid/tests/book/word2vec/no_test_word2vec_new_api.py#L109
sidgoyal78 approved these changes May 3, 2018
There was a problem hiding this comment.
Overall looks good. Probably, @helinwang or @cs2be can also take a look.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Once this PR is approved, I will add other book examples for understanding sentiment using other models.