Skip to content

EndToEnd tests: fix tear_down() #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

EndToEnd tests: fix tear_down() #1290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/EndToEnd/phpcbf_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash

function tear_down() {
rm -r tests/EndToEnd/Fixtures/*.fixed
rm -rf tests/EndToEnd/Fixtures/*.fixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need -r here.

Suggested change
rm -rf tests/EndToEnd/Fixtures/*.fixed
rm -f tests/EndToEnd/Fixtures/*.fixed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredden Yeah, I kind of had a feeling it wasn't needed, but for now just wanted to fix the E2E tests. Happy to receive any PRs which improve/expand them though ;-)
}

function test_phpcbf_is_working() {
Expand Down