EndToEnd tests: fix tear_down() #1290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BashUnit 0.25.0 improves the error reporting from the test fixture methods, which exposes a flaw in the `phpcbf_test.sh::tear_down()` method. Should be fixed now. Ref: * https://github.com/TypedDevs/bashunit/releases/tag/0.25.0 * TypedDevs/bashunit 489 * TypedDevs/bashunit 491
fredden reviewed Oct 6, 2025
| | ||
| function tear_down() { | ||
| rm -r tests/EndToEnd/Fixtures/*.fixed | ||
| rm -rf tests/EndToEnd/Fixtures/*.fixed |
There was a problem hiding this comment.
We don't need -r here.
Suggested change
| rm -rf tests/EndToEnd/Fixtures/*.fixed | |
| rm -f tests/EndToEnd/Fixtures/*.fixed |
There was a problem hiding this comment.
@fredden Yeah, I kind of had a feeling it wasn't needed, but for now just wanted to fix the E2E tests. Happy to receive any PRs which improve/expand them though ;-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
BashUnit 0.25.0 improves the error reporting from the test fixture methods, which exposes a flaw in the
phpcbf_test.sh::tear_down()method.Should be fixed now.
Ref:
set_up_before_scriptandtear_down_after_scriptfunctions? TypedDevs/bashunit#489Suggested changelog entry
N/A (test only change)