This repository was archived by the owner on Aug 7, 2021. It is now read-only.
Release 19.0 #755
Closed
Release 19.0 #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
## What is the current behavior? In NativeScript Angular the hot updates are only accepted in the entry file (`main.ts`). The lazy loaded NgModules are not directly imported anywhere in the dependency graph with root `main.ts`. That's why the hot updates in lazy modules don't bubble up to the accept in `main.ts` and HMR doesn't work in lazy modules. ## What is the new behavior? Every lazy loaded NgModule is augmented with HMR self-accept during build by the `lazy-ngmodule-hot-loader`. fixes NativeScript/nativescript-angular#1564 BREAKING CHANGES: The `lazy-ngmodule-hot-loader` should be added to the webpack configuration. **BEFORE** ``` js // webpack.config.js { test: /(?:\.ngfactory\.js|\.ngstyle\.js|\.ts)$/, use: [ "nativescript-dev-webpack/moduleid-compat-loader", "@ngtools/webpack", ] }, // ... ``` **AFTER** ``` js // webpack.config.js { test: /(?:\.ngfactory\.js|\.ngstyle\.js|\.ts)$/, use: [ "nativescript-dev-webpack/moduleid-compat-loader", "nativescript-dev-webpack/lazy-ngmodule-hot-loader", "@ngtools/webpack", ] }, // ... ```
A minor improvement over message formatting for unaccepted or declined HMR changes
…ion mode (#743) ## PR Checklist - [X] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. - [X] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. - [X] All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests ## What is the current behavior? When building {N} Vue apps in production mode the function names are renamed by UglifyJS to make the bundle smaller. This causes problems when some `tns-core-modules` components are renamed (`SegmentedBar`, `FormattedString`). ``` tns run ios --bundle --env.production ``` ## What is the new behavior? The function names are not renamed anymore. fixes nativescript-vue/vue-cli-template#105 for the {N} CLI Vue template.
…ths (#710) In the new {N} 5.0 templates for Angular the default paths are: - source code path - `src` - application resources path - `App_Resources`
* feat: transform the main angular module in order to include the lazy loader in the bundle when angular/core is external * fix pr comments * refactor: remove blank lines * fix: move a typescript specific logic in ast utils in order to avoid invalid import in JS applications * fix: normalize the app module paths in order to avoid incorrect comparison on Windows
sis0k0 suggested changes Jan 3, 2019
Contributor
sis0k0 left a comment
sis0k0 left a comment There was a problem hiding this comment.
There are already released features/fixes in the changelog.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.