This repository was archived by the owner on Aug 7, 2021. It is now read-only.
refactor(Angular): update the default source dir and App_Resources paths #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In the new {N} 5.0 templates the default paths are: - source code path - `src` - application resources path - `App_Resources` 
manoldonev reviewed Dec 14, 2018
templates/webpack.javascript.js Outdated
| // when bundling with `tns run android|ios --bundle`. | ||
| appPath = "app", | ||
| appResourcesPath = "app/App_Resources", | ||
| appPath = "src", |
There was a problem hiding this comment.
We changed the default paths only for the angular templates so far, ts/js/vue still use the app & app/App_Resources logic (e.g. https://github.com/NativeScript/template-blank-ts). We should update them first prior to updating the default webpack templates?
There was a problem hiding this comment.
I updated the PR to modify only the NG webpack config. After we migrate the other templates, I will open a PR that changes the non-NG webpack configs as well.
sis0k0 changed the title manoldonev approved these changes Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In the new {N} 5.0 templates for Angular the default paths are:
srcApp_Resources