Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d2195b8
Refactor the Imports and include typing and dataclass additionally
ishandutta0098 Mar 29, 2023
02dc56c
Replace hard coded config with a dataclass config
ishandutta0098 Mar 29, 2023
62ec623
Refactor the MNISTModel class
ishandutta0098 Mar 29, 2023
d2bfc22
Refactor DataLoader and Trainer
ishandutta0098 Mar 29, 2023
96af98d
Refactor LitMNIST Model
ishandutta0098 Mar 29, 2023
fc041fe
Refactor model initialization and trainer
ishandutta0098 Mar 29, 2023
bd2646b
Add ckpt_path to trainer.test() function
ishandutta0098 Mar 29, 2023
23fda51
Refactor logs
ishandutta0098 Mar 29, 2023
75501be
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 29, 2023
c5b3d42
Change Formatting Style & Remove info duplication
ishandutta0098 Mar 29, 2023
91288db
update
ishandutta0098 Mar 29, 2023
2321f9d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 29, 2023
dc13239
Remove typing info from training step docstring
ishandutta0098 Mar 29, 2023
286e9e0
Resolve merge conflict
ishandutta0098 Mar 29, 2023
5f5f4a7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 29, 2023
3c26517
Remove typehints from docstrings
ishandutta0098 Mar 31, 2023
9749919
Merge branch 'refactor-mnist-hello-world' of https://github.com/ishan…
ishandutta0098 Mar 31, 2023
ac49047
Merge branch 'main' into refactor-mnist-hello-world
ishandutta0098 Apr 2, 2023
bcda06a
Merge branch 'main' into refactor-mnist-hello-world
Borda May 3, 2023
bf47f8e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 3, 2023
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed May 3, 2023
commit bf47f8e689039f5a8e17a94cfe2de5d375d651e9
3 changes: 0 additions & 3 deletions lightning_examples/mnist-hello-world/hello-world.py
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ def training_step(self, batch: Tuple[torch.Tensor, torch.Tensor], batch_nb: int)
Returns:
(torch.Tensor): The training loss.
"""

x, y = batch
logits = self(x)
loss = F.nll_loss(logits, y)
Expand Down Expand Up @@ -408,7 +407,6 @@ def train_dataloader(self) -> DataLoader:
Returns:
DataLoader: The training DataLoader.
"""

return DataLoader(self.mnist_train, batch_size=config.batch_size)

def val_dataloader(self) -> DataLoader:
Expand All @@ -417,7 +415,6 @@ def val_dataloader(self) -> DataLoader:
Returns:
DataLoader: The validation DataLoader.
"""

return DataLoader(self.mnist_val, batch_size=config.batch_size)

def test_dataloader(self) -> DataLoader:
Expand Down