This repository was archived by the owner on Aug 28, 2025. It is now read-only.
Refactor mnist hello world example #241
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I have refactored the entire mnist hello world example, maintaining a similar structure but much more readable.
Following are the major changes:
dataclassconfig instead of hardcoded config valuesforward()function ofMNISTModelckpt_pathargument totrainer.test()to suppress the warningAdditional Information:
PR review
I am a member of the Lightning League and the refactoring has been discussed with @Borda
closes #240