Skip to content

Conversation

bradmiro
Copy link
Contributor

This PR adds a sample that creates a Dataproc cluster using the Java Client Library.

@bradmiro bradmiro requested review from a team and lesv November 14, 2019 00:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2019
@bradmiro
Copy link
Contributor Author

Most of @kurtisvg's suggestions fixed with these commits. I left a comment on one suggestion.

Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the one comment

@bradmiro bradmiro merged commit d1ac030 into master Nov 15, 2019
@bradmiro bradmiro deleted the dataproc-samples branch November 15, 2019 20:55
bourgeoisor pushed a commit that referenced this pull request Nov 11, 2022
* refactored and added tags to infinite speech streaming sample (#1605) * Changed 'main' region tag * Removed extra lines around tags and changed client import to v1 * Create dataproc directory and add CreateCluster sample * reverting changes to speech infinite streaming sample * Added java versions to pom * Several changes to file formatting as per request in the PR * Added comments to exceptions in CreateCluster, expanded exceptions and femoved endpoint configuring in CreateClusterTest.java * Fixed version for parent config * Added clarity to futures requests by expanding variables * Fixed linting errors * Fixed import ordering * Moved exceptions to function level in dataproc create cluster sample + test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants