refactored and added tags to infinite speech streaming sample #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
lesv reviewed Oct 7, 2019
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2018 Google LLC | |||
| * Copyright 2019 Google LLC | |||
There was a problem hiding this comment.
We don't change the copyright of the file on modification. Otherwise LGTM
bradmiro added a commit that referenced this pull request Nov 15, 2019
* refactored and added tags to infinite speech streaming sample (#1605) * Changed 'main' region tag * Removed extra lines around tags and changed client import to v1 * Create dataproc directory and add CreateCluster sample * reverting changes to speech infinite streaming sample * Added java versions to pom * Several changes to file formatting as per request in the PR * Added comments to exceptions in CreateCluster, expanded exceptions and femoved endpoint configuring in CreateClusterTest.java * Fixed version for parent config * Added clarity to futures requests by expanding variables * Fixed linting errors * Fixed import ordering * Moved exceptions to function level in dataproc create cluster sample + test
bradmiro added a commit that referenced this pull request Nov 16, 2019
* refactored and added tags to infinite speech streaming sample (#1605) * Changed 'main' region tag * Removed extra lines around tags and changed client import to v1 * Create dataproc directory and add CreateCluster sample * reverting changes to speech infinite streaming sample * Added java versions to pom * Several changes to file formatting as per request in the PR * Added comments to exceptions in CreateCluster, expanded exceptions and femoved endpoint configuring in CreateClusterTest.java * Fixed version for parent config * Added clarity to futures requests by expanding variables * Fixed linting errors * Fixed import ordering * Moved exceptions to function level in dataproc create cluster sample + test * Re-added endpoint to test, changed region tags to include 'dataproc', slight mod to pom * fix to pom
bradmiro added a commit that referenced this pull request Dec 2, 2019
bourgeoisor pushed a commit that referenced this pull request Nov 11, 2022
* refactored and added tags to infinite speech streaming sample (#1605) * Changed 'main' region tag * Removed extra lines around tags and changed client import to v1 * Create dataproc directory and add CreateCluster sample * reverting changes to speech infinite streaming sample * Added java versions to pom * Several changes to file formatting as per request in the PR * Added comments to exceptions in CreateCluster, expanded exceptions and femoved endpoint configuring in CreateClusterTest.java * Fixed version for parent config * Added clarity to futures requests by expanding variables * Fixed linting errors * Fixed import ordering * Moved exceptions to function level in dataproc create cluster sample + test
bourgeoisor pushed a commit that referenced this pull request Nov 11, 2022
* refactored and added tags to infinite speech streaming sample (#1605) * Changed 'main' region tag * Removed extra lines around tags and changed client import to v1 * Create dataproc directory and add CreateCluster sample * reverting changes to speech infinite streaming sample * Added java versions to pom * Several changes to file formatting as per request in the PR * Added comments to exceptions in CreateCluster, expanded exceptions and femoved endpoint configuring in CreateClusterTest.java * Fixed version for parent config * Added clarity to futures requests by expanding variables * Fixed linting errors * Fixed import ordering * Moved exceptions to function level in dataproc create cluster sample + test * Re-added endpoint to test, changed region tags to include 'dataproc', slight mod to pom * fix to pom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Staging for viewing in tutorial